diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2021-07-24 15:39:01 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-08-04 18:59:46 +0000 |
commit | 005c414e5f2a0ace3756da767d3920ac98cb5c76 (patch) | |
tree | 73b17f1e733ffb64a475657eefa21b17ac1ff7b9 /apps/gui | |
parent | ef41cc6623226f3ce7630211ef88640a48fb8e59 (diff) | |
download | rockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.tar.gz rockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.zip |
Document intentional fallthroughs + fix harmless unintended ones
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
Diffstat (limited to 'apps/gui')
-rw-r--r-- | apps/gui/list.c | 1 | ||||
-rw-r--r-- | apps/gui/statusbar-skinned.c | 1 | ||||
-rw-r--r-- | apps/gui/wps.c | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/apps/gui/list.c b/apps/gui/list.c index 36dbe44445..139dbaac18 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c | |||
@@ -748,6 +748,7 @@ bool gui_synclist_do_button(struct gui_synclist * lists, | |||
748 | return true; | 748 | return true; |
749 | } | 749 | } |
750 | *actionptr = ACTION_TREE_PGLEFT; | 750 | *actionptr = ACTION_TREE_PGLEFT; |
751 | /* fallthrough */ | ||
751 | case ACTION_TREE_PGLEFT: | 752 | case ACTION_TREE_PGLEFT: |
752 | if(pgleft_allow_cancel && (lists->offset_position[0] == 0)) | 753 | if(pgleft_allow_cancel && (lists->offset_position[0] == 0)) |
753 | { | 754 | { |
diff --git a/apps/gui/statusbar-skinned.c b/apps/gui/statusbar-skinned.c index 9b10ad4dce..63f3197faa 100644 --- a/apps/gui/statusbar-skinned.c +++ b/apps/gui/statusbar-skinned.c | |||
@@ -270,6 +270,7 @@ char* sb_create_from_settings(enum screen_type screen) | |||
270 | { | 270 | { |
271 | case STATUSBAR_TOP: | 271 | case STATUSBAR_TOP: |
272 | y = STATUSBAR_HEIGHT; | 272 | y = STATUSBAR_HEIGHT; |
273 | /* Fallthrough */ | ||
273 | case STATUSBAR_BOTTOM: | 274 | case STATUSBAR_BOTTOM: |
274 | height = screens[screen].lcdheight - STATUSBAR_HEIGHT; | 275 | height = screens[screen].lcdheight - STATUSBAR_HEIGHT; |
275 | break; | 276 | break; |
diff --git a/apps/gui/wps.c b/apps/gui/wps.c index 35716087c2..e491d6f35b 100644 --- a/apps/gui/wps.c +++ b/apps/gui/wps.c | |||
@@ -223,6 +223,7 @@ bool ffwd_rew(int button) | |||
223 | { | 223 | { |
224 | case ACTION_WPS_SEEKFWD: | 224 | case ACTION_WPS_SEEKFWD: |
225 | direction = 1; | 225 | direction = 1; |
226 | /* Fallthrough */ | ||
226 | case ACTION_WPS_SEEKBACK: | 227 | case ACTION_WPS_SEEKBACK: |
227 | if (skin_get_global_state()->ff_rewind) | 228 | if (skin_get_global_state()->ff_rewind) |
228 | { | 229 | { |