From 005c414e5f2a0ace3756da767d3920ac98cb5c76 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sat, 24 Jul 2021 15:39:01 +0100 Subject: Document intentional fallthroughs + fix harmless unintended ones Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b --- apps/gui/list.c | 1 + apps/gui/statusbar-skinned.c | 1 + apps/gui/wps.c | 1 + 3 files changed, 3 insertions(+) (limited to 'apps/gui') diff --git a/apps/gui/list.c b/apps/gui/list.c index 36dbe44445..139dbaac18 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c @@ -748,6 +748,7 @@ bool gui_synclist_do_button(struct gui_synclist * lists, return true; } *actionptr = ACTION_TREE_PGLEFT; + /* fallthrough */ case ACTION_TREE_PGLEFT: if(pgleft_allow_cancel && (lists->offset_position[0] == 0)) { diff --git a/apps/gui/statusbar-skinned.c b/apps/gui/statusbar-skinned.c index 9b10ad4dce..63f3197faa 100644 --- a/apps/gui/statusbar-skinned.c +++ b/apps/gui/statusbar-skinned.c @@ -270,6 +270,7 @@ char* sb_create_from_settings(enum screen_type screen) { case STATUSBAR_TOP: y = STATUSBAR_HEIGHT; + /* Fallthrough */ case STATUSBAR_BOTTOM: height = screens[screen].lcdheight - STATUSBAR_HEIGHT; break; diff --git a/apps/gui/wps.c b/apps/gui/wps.c index 35716087c2..e491d6f35b 100644 --- a/apps/gui/wps.c +++ b/apps/gui/wps.c @@ -223,6 +223,7 @@ bool ffwd_rew(int button) { case ACTION_WPS_SEEKFWD: direction = 1; + /* Fallthrough */ case ACTION_WPS_SEEKBACK: if (skin_get_global_state()->ff_rewind) { -- cgit v1.2.3