diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2021-07-24 15:39:01 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-08-04 18:59:46 +0000 |
commit | 005c414e5f2a0ace3756da767d3920ac98cb5c76 (patch) | |
tree | 73b17f1e733ffb64a475657eefa21b17ac1ff7b9 /apps | |
parent | ef41cc6623226f3ce7630211ef88640a48fb8e59 (diff) | |
download | rockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.tar.gz rockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.zip |
Document intentional fallthroughs + fix harmless unintended ones
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
Diffstat (limited to 'apps')
-rw-r--r-- | apps/debug_menu.c | 3 | ||||
-rw-r--r-- | apps/gui/list.c | 1 | ||||
-rw-r--r-- | apps/gui/statusbar-skinned.c | 1 | ||||
-rw-r--r-- | apps/gui/wps.c | 1 | ||||
-rw-r--r-- | apps/onplay.c | 3 | ||||
-rw-r--r-- | apps/plugins/bubbles.c | 4 | ||||
-rw-r--r-- | apps/plugins/calculator.c | 2 | ||||
-rw-r--r-- | apps/plugins/chessbox/chessbox.c | 1 | ||||
-rw-r--r-- | apps/plugins/doom/p_ceilng.c | 3 | ||||
-rw-r--r-- | apps/plugins/doom/p_floor.c | 1 | ||||
-rw-r--r-- | apps/plugins/goban/goban.c | 1 | ||||
-rw-r--r-- | apps/plugins/imageviewer/imageviewer.c | 2 | ||||
-rw-r--r-- | apps/plugins/lrcplayer.c | 1 | ||||
-rw-r--r-- | apps/plugins/metronome.c | 2 | ||||
-rw-r--r-- | apps/plugins/mpegplayer/libmpeg2/header.c | 1 | ||||
-rw-r--r-- | apps/plugins/random_folder_advance_config.c | 1 | ||||
-rw-r--r-- | apps/plugins/rocklife.c | 1 | ||||
-rw-r--r-- | apps/plugins/rockpaint.c | 1 | ||||
-rw-r--r-- | apps/tagcache.c | 1 | ||||
-rw-r--r-- | apps/usb_keymaps.c | 1 |
20 files changed, 30 insertions, 2 deletions
diff --git a/apps/debug_menu.c b/apps/debug_menu.c index 02dc19359b..800e485ce3 100644 --- a/apps/debug_menu.c +++ b/apps/debug_menu.c | |||
@@ -1726,6 +1726,7 @@ static bool dbg_disk_info(void) | |||
1726 | #ifdef HAVE_DIRCACHE | 1726 | #ifdef HAVE_DIRCACHE |
1727 | static int dircache_callback(int btn, struct gui_synclist *lists) | 1727 | static int dircache_callback(int btn, struct gui_synclist *lists) |
1728 | { | 1728 | { |
1729 | (void)lists; | ||
1729 | struct dircache_info info; | 1730 | struct dircache_info info; |
1730 | dircache_get_info(&info); | 1731 | dircache_get_info(&info); |
1731 | 1732 | ||
@@ -1737,6 +1738,7 @@ static int dircache_callback(int btn, struct gui_synclist *lists) | |||
1737 | splash(HZ/2, "Rebuilding cache"); | 1738 | splash(HZ/2, "Rebuilding cache"); |
1738 | dircache_suspend(); | 1739 | dircache_suspend(); |
1739 | *(int *)lists->data = dircache_resume(); | 1740 | *(int *)lists->data = dircache_resume(); |
1741 | /* Fallthrough */ | ||
1740 | case ACTION_UNKNOWN: | 1742 | case ACTION_UNKNOWN: |
1741 | btn = ACTION_NONE; | 1743 | btn = ACTION_NONE; |
1742 | break; | 1744 | break; |
@@ -1776,7 +1778,6 @@ static int dircache_callback(int btn, struct gui_synclist *lists) | |||
1776 | btn = ACTION_REDRAW; | 1778 | btn = ACTION_REDRAW; |
1777 | 1779 | ||
1778 | return btn; | 1780 | return btn; |
1779 | (void)lists; | ||
1780 | } | 1781 | } |
1781 | 1782 | ||
1782 | static bool dbg_dircache_info(void) | 1783 | static bool dbg_dircache_info(void) |
diff --git a/apps/gui/list.c b/apps/gui/list.c index 36dbe44445..139dbaac18 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c | |||
@@ -748,6 +748,7 @@ bool gui_synclist_do_button(struct gui_synclist * lists, | |||
748 | return true; | 748 | return true; |
749 | } | 749 | } |
750 | *actionptr = ACTION_TREE_PGLEFT; | 750 | *actionptr = ACTION_TREE_PGLEFT; |
751 | /* fallthrough */ | ||
751 | case ACTION_TREE_PGLEFT: | 752 | case ACTION_TREE_PGLEFT: |
752 | if(pgleft_allow_cancel && (lists->offset_position[0] == 0)) | 753 | if(pgleft_allow_cancel && (lists->offset_position[0] == 0)) |
753 | { | 754 | { |
diff --git a/apps/gui/statusbar-skinned.c b/apps/gui/statusbar-skinned.c index 9b10ad4dce..63f3197faa 100644 --- a/apps/gui/statusbar-skinned.c +++ b/apps/gui/statusbar-skinned.c | |||
@@ -270,6 +270,7 @@ char* sb_create_from_settings(enum screen_type screen) | |||
270 | { | 270 | { |
271 | case STATUSBAR_TOP: | 271 | case STATUSBAR_TOP: |
272 | y = STATUSBAR_HEIGHT; | 272 | y = STATUSBAR_HEIGHT; |
273 | /* Fallthrough */ | ||
273 | case STATUSBAR_BOTTOM: | 274 | case STATUSBAR_BOTTOM: |
274 | height = screens[screen].lcdheight - STATUSBAR_HEIGHT; | 275 | height = screens[screen].lcdheight - STATUSBAR_HEIGHT; |
275 | break; | 276 | break; |
diff --git a/apps/gui/wps.c b/apps/gui/wps.c index 35716087c2..e491d6f35b 100644 --- a/apps/gui/wps.c +++ b/apps/gui/wps.c | |||
@@ -223,6 +223,7 @@ bool ffwd_rew(int button) | |||
223 | { | 223 | { |
224 | case ACTION_WPS_SEEKFWD: | 224 | case ACTION_WPS_SEEKFWD: |
225 | direction = 1; | 225 | direction = 1; |
226 | /* Fallthrough */ | ||
226 | case ACTION_WPS_SEEKBACK: | 227 | case ACTION_WPS_SEEKBACK: |
227 | if (skin_get_global_state()->ff_rewind) | 228 | if (skin_get_global_state()->ff_rewind) |
228 | { | 229 | { |
diff --git a/apps/onplay.c b/apps/onplay.c index 0942d69d3f..a5a92e7c1c 100644 --- a/apps/onplay.c +++ b/apps/onplay.c | |||
@@ -1441,10 +1441,13 @@ static int clipboard_paste(void) | |||
1441 | { | 1441 | { |
1442 | case OPRC_CANCELLED: | 1442 | case OPRC_CANCELLED: |
1443 | splash_cancelled(); | 1443 | splash_cancelled(); |
1444 | /* Fallthrough */ | ||
1444 | case OPRC_SUCCESS: | 1445 | case OPRC_SUCCESS: |
1445 | onplay_result = ONPLAY_RELOAD_DIR; | 1446 | onplay_result = ONPLAY_RELOAD_DIR; |
1447 | /* Fallthrough */ | ||
1446 | case OPRC_NOOP: | 1448 | case OPRC_NOOP: |
1447 | clipboard_clear_selection(&clipboard); | 1449 | clipboard_clear_selection(&clipboard); |
1450 | /* Fallthrough */ | ||
1448 | case OPRC_NOOVERWRT: | 1451 | case OPRC_NOOVERWRT: |
1449 | break; | 1452 | break; |
1450 | default: | 1453 | default: |
diff --git a/apps/plugins/bubbles.c b/apps/plugins/bubbles.c index ffc814e7a0..88d7228d72 100644 --- a/apps/plugins/bubbles.c +++ b/apps/plugins/bubbles.c | |||
@@ -76,7 +76,7 @@ enum { | |||
76 | #endif | 76 | #endif |
77 | 77 | ||
78 | #define ANGLE_STEP 2 | 78 | #define ANGLE_STEP 2 |
79 | #define ANGLE_STEP_REP 4 | 79 | #define ANGLE_STEP_REP 6 |
80 | 80 | ||
81 | #define BUBBLES_QUIT1 PLA_EXIT | 81 | #define BUBBLES_QUIT1 PLA_EXIT |
82 | #define BUBBLES_QUIT2 PLA_CANCEL | 82 | #define BUBBLES_QUIT2 PLA_CANCEL |
@@ -2367,12 +2367,14 @@ static int bubbles_handlebuttons(struct game_context* bb, bool animblock, | |||
2367 | switch(button){ | 2367 | switch(button){ |
2368 | case BUBBLES_LEFT_REP: | 2368 | case BUBBLES_LEFT_REP: |
2369 | if(bb->angle > MIN_ANGLE) bb->angle -= ANGLE_STEP_REP; | 2369 | if(bb->angle > MIN_ANGLE) bb->angle -= ANGLE_STEP_REP; |
2370 | break; | ||
2370 | case BUBBLES_LEFT: /* change angle to the left */ | 2371 | case BUBBLES_LEFT: /* change angle to the left */ |
2371 | if(bb->angle > MIN_ANGLE) bb->angle -= ANGLE_STEP; | 2372 | if(bb->angle > MIN_ANGLE) bb->angle -= ANGLE_STEP; |
2372 | break; | 2373 | break; |
2373 | 2374 | ||
2374 | case BUBBLES_RIGHT_REP: | 2375 | case BUBBLES_RIGHT_REP: |
2375 | if(bb->angle < MAX_ANGLE) bb->angle += ANGLE_STEP_REP; | 2376 | if(bb->angle < MAX_ANGLE) bb->angle += ANGLE_STEP_REP; |
2377 | break; | ||
2376 | case BUBBLES_RIGHT: /* change angle to the right */ | 2378 | case BUBBLES_RIGHT: /* change angle to the right */ |
2377 | if(bb->angle < MAX_ANGLE) bb->angle += ANGLE_STEP; | 2379 | if(bb->angle < MAX_ANGLE) bb->angle += ANGLE_STEP; |
2378 | break; | 2380 | break; |
diff --git a/apps/plugins/calculator.c b/apps/plugins/calculator.c index bd09330529..5bab15d7ed 100644 --- a/apps/plugins/calculator.c +++ b/apps/plugins/calculator.c | |||
@@ -755,6 +755,7 @@ double strtod(const char *nptr, char **endptr) | |||
755 | case '.': | 755 | case '.': |
756 | case '\'': | 756 | case '\'': |
757 | end=1; | 757 | end=1; |
758 | /* fallthrough */ | ||
758 | default: | 759 | default: |
759 | nptr++; | 760 | nptr++; |
760 | } | 761 | } |
@@ -1687,6 +1688,7 @@ static void typingProcess(void){ | |||
1687 | clearInput(); | 1688 | clearInput(); |
1688 | *typingbufPointer = '0'; | 1689 | *typingbufPointer = '0'; |
1689 | typingbufPointer++; | 1690 | typingbufPointer++; |
1691 | /* Fallthrough */ | ||
1690 | case cal_typing: | 1692 | case cal_typing: |
1691 | calStatus = cal_dotted; | 1693 | calStatus = cal_dotted; |
1692 | *typingbufPointer = '.'; | 1694 | *typingbufPointer = '.'; |
diff --git a/apps/plugins/chessbox/chessbox.c b/apps/plugins/chessbox/chessbox.c index 397fd0e559..13df4f177e 100644 --- a/apps/plugins/chessbox/chessbox.c +++ b/apps/plugins/chessbox/chessbox.c | |||
@@ -780,6 +780,7 @@ static bool cb_start_viewer(const char* filename){ | |||
780 | break; | 780 | break; |
781 | case COMMAND_QUIT: | 781 | case COMMAND_QUIT: |
782 | exit_app = true; | 782 | exit_app = true; |
783 | /* fallthrough */ | ||
783 | case COMMAND_RETURN: | 784 | case COMMAND_RETURN: |
784 | exit_viewer = true; | 785 | exit_viewer = true; |
785 | break; | 786 | break; |
diff --git a/apps/plugins/doom/p_ceilng.c b/apps/plugins/doom/p_ceilng.c index db5a701b1a..f83bdc0260 100644 --- a/apps/plugins/doom/p_ceilng.c +++ b/apps/plugins/doom/p_ceilng.c | |||
@@ -121,6 +121,7 @@ void T_MoveCeiling (ceiling_t* ceiling) | |||
121 | // crushers reverse direction at the top | 121 | // crushers reverse direction at the top |
122 | case silentCrushAndRaise: | 122 | case silentCrushAndRaise: |
123 | S_StartSound((mobj_t *)&ceiling->sector->soundorg,sfx_pstop); | 123 | S_StartSound((mobj_t *)&ceiling->sector->soundorg,sfx_pstop); |
124 | /* fallthrough */ | ||
124 | case genSilentCrusher: | 125 | case genSilentCrusher: |
125 | case genCrusher: | 126 | case genCrusher: |
126 | case fastCrushAndRaise: | 127 | case fastCrushAndRaise: |
@@ -177,8 +178,10 @@ void T_MoveCeiling (ceiling_t* ceiling) | |||
177 | // except generalized ones, reset speed, start back up | 178 | // except generalized ones, reset speed, start back up |
178 | case silentCrushAndRaise: | 179 | case silentCrushAndRaise: |
179 | S_StartSound((mobj_t *)&ceiling->sector->soundorg,sfx_pstop); | 180 | S_StartSound((mobj_t *)&ceiling->sector->soundorg,sfx_pstop); |
181 | /* fallthrough */ | ||
180 | case crushAndRaise: | 182 | case crushAndRaise: |
181 | ceiling->speed = CEILSPEED; | 183 | ceiling->speed = CEILSPEED; |
184 | /* fallthrough */ | ||
182 | case fastCrushAndRaise: | 185 | case fastCrushAndRaise: |
183 | ceiling->direction = 1; | 186 | ceiling->direction = 1; |
184 | break; | 187 | break; |
diff --git a/apps/plugins/doom/p_floor.c b/apps/plugins/doom/p_floor.c index f4dbcd04f5..953e4dd09d 100644 --- a/apps/plugins/doom/p_floor.c +++ b/apps/plugins/doom/p_floor.c | |||
@@ -503,6 +503,7 @@ int EV_DoFloor | |||
503 | 503 | ||
504 | case raiseFloorCrush: | 504 | case raiseFloorCrush: |
505 | floor->crush = true; | 505 | floor->crush = true; |
506 | /* fallthrough */ | ||
506 | case raiseFloor: | 507 | case raiseFloor: |
507 | floor->direction = 1; | 508 | floor->direction = 1; |
508 | floor->sector = sec; | 509 | floor->sector = sec; |
diff --git a/apps/plugins/goban/goban.c b/apps/plugins/goban/goban.c index 7b378eebff..b041f7cd73 100644 --- a/apps/plugins/goban/goban.c +++ b/apps/plugins/goban/goban.c | |||
@@ -524,6 +524,7 @@ plugin_start (const void *parameter) | |||
524 | 524 | ||
525 | case BUTTON_NONE: | 525 | case BUTTON_NONE: |
526 | is_idle = true; | 526 | is_idle = true; |
527 | /* fallthrough */ | ||
527 | default: | 528 | default: |
528 | if (rb->default_event_handler (btn) == SYS_USB_CONNECTED) | 529 | if (rb->default_event_handler (btn) == SYS_USB_CONNECTED) |
529 | { | 530 | { |
diff --git a/apps/plugins/imageviewer/imageviewer.c b/apps/plugins/imageviewer/imageviewer.c index 4b1a982438..508cf1a5b5 100644 --- a/apps/plugins/imageviewer/imageviewer.c +++ b/apps/plugins/imageviewer/imageviewer.c | |||
@@ -600,6 +600,7 @@ static int scroll_bmp(struct image_info *info) | |||
600 | if (entries > 1 && info->width <= LCD_WIDTH | 600 | if (entries > 1 && info->width <= LCD_WIDTH |
601 | && info->height <= LCD_HEIGHT) | 601 | && info->height <= LCD_HEIGHT) |
602 | return change_filename(DIR_PREV); | 602 | return change_filename(DIR_PREV); |
603 | /* fallthrough */ | ||
603 | case IMGVIEW_LEFT | BUTTON_REPEAT: | 604 | case IMGVIEW_LEFT | BUTTON_REPEAT: |
604 | pan_view_left(info); | 605 | pan_view_left(info); |
605 | break; | 606 | break; |
@@ -608,6 +609,7 @@ static int scroll_bmp(struct image_info *info) | |||
608 | if (entries > 1 && info->width <= LCD_WIDTH | 609 | if (entries > 1 && info->width <= LCD_WIDTH |
609 | && info->height <= LCD_HEIGHT) | 610 | && info->height <= LCD_HEIGHT) |
610 | return change_filename(DIR_NEXT); | 611 | return change_filename(DIR_NEXT); |
612 | /* fallthrough */ | ||
611 | case IMGVIEW_RIGHT | BUTTON_REPEAT: | 613 | case IMGVIEW_RIGHT | BUTTON_REPEAT: |
612 | pan_view_right(info); | 614 | pan_view_right(info); |
613 | break; | 615 | break; |
diff --git a/apps/plugins/lrcplayer.c b/apps/plugins/lrcplayer.c index 2abfbef6c9..225f0c8689 100644 --- a/apps/plugins/lrcplayer.c +++ b/apps/plugins/lrcplayer.c | |||
@@ -227,6 +227,7 @@ static int lrc_set_time(const char *title, const char *unit, long *pval, | |||
227 | case PLA_UP_REPEAT: | 227 | case PLA_UP_REPEAT: |
228 | case PLA_DOWN_REPEAT: | 228 | case PLA_DOWN_REPEAT: |
229 | mult *= 10; | 229 | mult *= 10; |
230 | /* fallthrough */ | ||
230 | case PLA_DOWN: | 231 | case PLA_DOWN: |
231 | case PLA_UP: | 232 | case PLA_UP: |
232 | if (button == PLA_DOWN_REPEAT || button == PLA_DOWN) | 233 | if (button == PLA_DOWN_REPEAT || button == PLA_DOWN) |
diff --git a/apps/plugins/metronome.c b/apps/plugins/metronome.c index a6b4181df2..157d116ff9 100644 --- a/apps/plugins/metronome.c +++ b/apps/plugins/metronome.c | |||
@@ -1663,11 +1663,13 @@ enum plugin_status plugin_start(const void* file) | |||
1663 | break; | 1663 | break; |
1664 | case METRONOME_LEFT: | 1664 | case METRONOME_LEFT: |
1665 | bpm_step_counter = 0; | 1665 | bpm_step_counter = 0; |
1666 | /* fallthrough */ | ||
1666 | case METRONOME_LEFT_REP: | 1667 | case METRONOME_LEFT_REP: |
1667 | change_bpm(-1); | 1668 | change_bpm(-1); |
1668 | break; | 1669 | break; |
1669 | case METRONOME_RIGHT: | 1670 | case METRONOME_RIGHT: |
1670 | bpm_step_counter = 0; | 1671 | bpm_step_counter = 0; |
1672 | /* fallthrough */ | ||
1671 | case METRONOME_RIGHT_REP: | 1673 | case METRONOME_RIGHT_REP: |
1672 | change_bpm(1); | 1674 | change_bpm(1); |
1673 | break; | 1675 | break; |
diff --git a/apps/plugins/mpegplayer/libmpeg2/header.c b/apps/plugins/mpegplayer/libmpeg2/header.c index 001cafe7d5..b40193a338 100644 --- a/apps/plugins/mpegplayer/libmpeg2/header.c +++ b/apps/plugins/mpegplayer/libmpeg2/header.c | |||
@@ -307,6 +307,7 @@ static int sequence_ext (mpeg2dec_t * mpeg2dec) | |||
307 | return 1; | 307 | return 1; |
308 | case 2: /* 4:2:0 */ | 308 | case 2: /* 4:2:0 */ |
309 | sequence->chroma_height >>= 1; | 309 | sequence->chroma_height >>= 1; |
310 | /* fallthrough */ | ||
310 | case 4: /* 4:2:2 */ | 311 | case 4: /* 4:2:2 */ |
311 | sequence->chroma_width >>= 1; | 312 | sequence->chroma_width >>= 1; |
312 | } | 313 | } |
diff --git a/apps/plugins/random_folder_advance_config.c b/apps/plugins/random_folder_advance_config.c index c9dce0223b..ca0d5f397d 100644 --- a/apps/plugins/random_folder_advance_config.c +++ b/apps/plugins/random_folder_advance_config.c | |||
@@ -366,6 +366,7 @@ static int edit_list(void) | |||
366 | { | 366 | { |
367 | case 0: | 367 | case 0: |
368 | save_list(); | 368 | save_list(); |
369 | /* fallthrough */ | ||
369 | case 1: | 370 | case 1: |
370 | exit = true; | 371 | exit = true; |
371 | ret = -2; | 372 | ret = -2; |
diff --git a/apps/plugins/rocklife.c b/apps/plugins/rocklife.c index 0be48dcce8..99297abd0f 100644 --- a/apps/plugins/rocklife.c +++ b/apps/plugins/rocklife.c | |||
@@ -150,6 +150,7 @@ static bool load_cellfile(const char *file, char *pgrid){ | |||
150 | switch(c) { | 150 | switch(c) { |
151 | case '!': | 151 | case '!': |
152 | comment = true; | 152 | comment = true; |
153 | break; | ||
153 | case '.': | 154 | case '.': |
154 | if (!comment) | 155 | if (!comment) |
155 | x++; | 156 | x++; |
diff --git a/apps/plugins/rockpaint.c b/apps/plugins/rockpaint.c index a0d9b26ec2..09fa2c8c5f 100644 --- a/apps/plugins/rockpaint.c +++ b/apps/plugins/rockpaint.c | |||
@@ -1907,6 +1907,7 @@ static void draw_text( int x, int y ) | |||
1907 | rb->lcd_set_foreground( rp_colors[ drawcolor ] ); | 1907 | rb->lcd_set_foreground( rp_colors[ drawcolor ] ); |
1908 | buffer_putsxyofs( save_buffer, COLS, ROWS, x, y, 0, | 1908 | buffer_putsxyofs( save_buffer, COLS, ROWS, x, y, 0, |
1909 | buffer->text.text ); | 1909 | buffer->text.text ); |
1910 | /* fallthrough */ | ||
1910 | case TEXT_MENU_CANCEL: | 1911 | case TEXT_MENU_CANCEL: |
1911 | default: | 1912 | default: |
1912 | restore_screen(); | 1913 | restore_screen(); |
diff --git a/apps/tagcache.c b/apps/tagcache.c index 37e389444a..2e705d658e 100644 --- a/apps/tagcache.c +++ b/apps/tagcache.c | |||
@@ -4824,6 +4824,7 @@ static void tagcache_thread(void) | |||
4824 | 4824 | ||
4825 | case Q_START_SCAN: | 4825 | case Q_START_SCAN: |
4826 | check_done = false; | 4826 | check_done = false; |
4827 | /* fallthrough */ | ||
4827 | case SYS_TIMEOUT: | 4828 | case SYS_TIMEOUT: |
4828 | if (check_done || !tc_stat.ready) | 4829 | if (check_done || !tc_stat.ready) |
4829 | break ; | 4830 | break ; |
diff --git a/apps/usb_keymaps.c b/apps/usb_keymaps.c index bd72d95be8..2781fb5532 100644 --- a/apps/usb_keymaps.c +++ b/apps/usb_keymaps.c | |||
@@ -181,6 +181,7 @@ int get_hid_usb_action(void) | |||
181 | { | 181 | { |
182 | case ACTION_USB_HID_MODE_SWITCH_NEXT: | 182 | case ACTION_USB_HID_MODE_SWITCH_NEXT: |
183 | step = 1; | 183 | step = 1; |
184 | /* fallthrough */ | ||
184 | case ACTION_USB_HID_MODE_SWITCH_PREV: | 185 | case ACTION_USB_HID_MODE_SWITCH_PREV: |
185 | /* Switch key mappings in a cyclic way */ | 186 | /* Switch key mappings in a cyclic way */ |
186 | usb_keypad_mode = clamp_value_wrap(usb_keypad_mode + step, | 187 | usb_keypad_mode = clamp_value_wrap(usb_keypad_mode + step, |