diff options
author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2021-12-28 16:40:16 +0100 |
---|---|---|
committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2021-12-28 17:57:04 +0100 |
commit | f53f1fbafab6f994a4ed5f63d884d27c42739d53 (patch) | |
tree | c6060e771d096cbe9b97d95bef5d7cb0a8ac4824 /utils/rbutilqt/base | |
parent | 7dffbd84af8d4857f357ac33bd74fda3608c7ebd (diff) | |
download | rockbox-f53f1fbafab6f994a4ed5f63d884d27c42739d53.tar.gz rockbox-f53f1fbafab6f994a4ed5f63d884d27c42739d53.zip |
rbutil: Fix some more issues found by clazy.
Change-Id: I0a1a849ecea4b4666b08ccb050eb17918e90a258
Diffstat (limited to 'utils/rbutilqt/base')
-rw-r--r-- | utils/rbutilqt/base/httpget.h | 1 | ||||
-rw-r--r-- | utils/rbutilqt/base/mspackutil.h | 4 | ||||
-rw-r--r-- | utils/rbutilqt/base/utils.cpp | 4 | ||||
-rw-r--r-- | utils/rbutilqt/base/ziputil.h | 4 |
4 files changed, 2 insertions, 11 deletions
diff --git a/utils/rbutilqt/base/httpget.h b/utils/rbutilqt/base/httpget.h index dfd7b87c89..472ad83b81 100644 --- a/utils/rbutilqt/base/httpget.h +++ b/utils/rbutilqt/base/httpget.h | |||
@@ -80,7 +80,6 @@ class HttpGet : public QObject | |||
80 | signals: | 80 | signals: |
81 | void done(bool); | 81 | void done(bool); |
82 | void dataReadProgress(int, int); | 82 | void dataReadProgress(int, int); |
83 | void requestFinished(int, bool); | ||
84 | void headerFinished(void); | 83 | void headerFinished(void); |
85 | 84 | ||
86 | private slots: | 85 | private slots: |
diff --git a/utils/rbutilqt/base/mspackutil.h b/utils/rbutilqt/base/mspackutil.h index 1cb4350b13..447ab9e802 100644 --- a/utils/rbutilqt/base/mspackutil.h +++ b/utils/rbutilqt/base/mspackutil.h | |||
@@ -36,10 +36,6 @@ class MsPackUtil : public ArchiveUtil | |||
36 | virtual bool extractArchive(const QString& dest, QString file = ""); | 36 | virtual bool extractArchive(const QString& dest, QString file = ""); |
37 | virtual QStringList files(void); | 37 | virtual QStringList files(void); |
38 | 38 | ||
39 | signals: | ||
40 | void logProgress(int, int); | ||
41 | void logItem(QString, int); | ||
42 | |||
43 | private: | 39 | private: |
44 | QString errorStringMsPack(int error) const; | 40 | QString errorStringMsPack(int error) const; |
45 | struct mscab_decompressor* m_cabd; | 41 | struct mscab_decompressor* m_cabd; |
diff --git a/utils/rbutilqt/base/utils.cpp b/utils/rbutilqt/base/utils.cpp index 285d48d6cf..b834567688 100644 --- a/utils/rbutilqt/base/utils.cpp +++ b/utils/rbutilqt/base/utils.cpp | |||
@@ -1053,11 +1053,11 @@ qint64 Utils::recursiveFolderSize(QString path) | |||
1053 | { | 1053 | { |
1054 | qint64 size = 0; | 1054 | qint64 size = 0; |
1055 | QList<QFileInfo> items = QDir(path).entryInfoList(QDir::Files | QDir::NoDotAndDotDot); | 1055 | QList<QFileInfo> items = QDir(path).entryInfoList(QDir::Files | QDir::NoDotAndDotDot); |
1056 | for (auto item: items) { | 1056 | for (const auto &item: qAsConst(items)) { |
1057 | size += item.size(); | 1057 | size += item.size(); |
1058 | } | 1058 | } |
1059 | QList<QString> folders = QDir(path).entryList(QDir::Dirs | QDir::NoDotAndDotDot); | 1059 | QList<QString> folders = QDir(path).entryList(QDir::Dirs | QDir::NoDotAndDotDot); |
1060 | for (auto const& folder: folders) { | 1060 | for (auto const& folder: qAsConst(folders)) { |
1061 | size += recursiveFolderSize(path + "/" + folder); | 1061 | size += recursiveFolderSize(path + "/" + folder); |
1062 | } | 1062 | } |
1063 | return size; | 1063 | return size; |
diff --git a/utils/rbutilqt/base/ziputil.h b/utils/rbutilqt/base/ziputil.h index 25c3dce391..73a87a820a 100644 --- a/utils/rbutilqt/base/ziputil.h +++ b/utils/rbutilqt/base/ziputil.h | |||
@@ -40,10 +40,6 @@ class ZipUtil : public ArchiveUtil | |||
40 | qint64 totalUncompressedSize(unsigned int clustersize = 0); | 40 | qint64 totalUncompressedSize(unsigned int clustersize = 0); |
41 | virtual QStringList files(void); | 41 | virtual QStringList files(void); |
42 | 42 | ||
43 | signals: | ||
44 | void logProgress(int, int); | ||
45 | void logItem(QString, int); | ||
46 | |||
47 | private: | 43 | private: |
48 | QList<QuaZipFileInfo> contentProperties(); | 44 | QList<QuaZipFileInfo> contentProperties(); |
49 | QuaZip* m_zip; | 45 | QuaZip* m_zip; |