From f53f1fbafab6f994a4ed5f63d884d27c42739d53 Mon Sep 17 00:00:00 2001
From: Dominik Riebeling <Dominik.Riebeling@gmail.com>
Date: Tue, 28 Dec 2021 16:40:16 +0100
Subject: rbutil: Fix some more issues found by clazy.

Change-Id: I0a1a849ecea4b4666b08ccb050eb17918e90a258
---
 utils/rbutilqt/base/httpget.h    | 1 -
 utils/rbutilqt/base/mspackutil.h | 4 ----
 utils/rbutilqt/base/utils.cpp    | 4 ++--
 utils/rbutilqt/base/ziputil.h    | 4 ----
 4 files changed, 2 insertions(+), 11 deletions(-)

(limited to 'utils/rbutilqt/base')

diff --git a/utils/rbutilqt/base/httpget.h b/utils/rbutilqt/base/httpget.h
index dfd7b87c89..472ad83b81 100644
--- a/utils/rbutilqt/base/httpget.h
+++ b/utils/rbutilqt/base/httpget.h
@@ -80,7 +80,6 @@ class HttpGet : public QObject
     signals:
         void done(bool);
         void dataReadProgress(int, int);
-        void requestFinished(int, bool);
         void headerFinished(void);
 
     private slots:
diff --git a/utils/rbutilqt/base/mspackutil.h b/utils/rbutilqt/base/mspackutil.h
index 1cb4350b13..447ab9e802 100644
--- a/utils/rbutilqt/base/mspackutil.h
+++ b/utils/rbutilqt/base/mspackutil.h
@@ -36,10 +36,6 @@ class MsPackUtil : public ArchiveUtil
         virtual bool extractArchive(const QString& dest, QString file = "");
         virtual QStringList files(void);
 
-    signals:
-       void logProgress(int, int);
-       void logItem(QString, int);
-
     private:
         QString errorStringMsPack(int error) const;
         struct mscab_decompressor* m_cabd;
diff --git a/utils/rbutilqt/base/utils.cpp b/utils/rbutilqt/base/utils.cpp
index 285d48d6cf..b834567688 100644
--- a/utils/rbutilqt/base/utils.cpp
+++ b/utils/rbutilqt/base/utils.cpp
@@ -1053,11 +1053,11 @@ qint64 Utils::recursiveFolderSize(QString path)
 {
     qint64 size = 0;
     QList<QFileInfo> items = QDir(path).entryInfoList(QDir::Files | QDir::NoDotAndDotDot);
-    for (auto item: items) {
+    for (const auto &item: qAsConst(items)) {
         size += item.size();
     }
     QList<QString> folders = QDir(path).entryList(QDir::Dirs | QDir::NoDotAndDotDot);
-    for (auto const& folder: folders) {
+    for (auto const& folder: qAsConst(folders)) {
         size += recursiveFolderSize(path + "/" + folder);
     }
     return size;
diff --git a/utils/rbutilqt/base/ziputil.h b/utils/rbutilqt/base/ziputil.h
index 25c3dce391..73a87a820a 100644
--- a/utils/rbutilqt/base/ziputil.h
+++ b/utils/rbutilqt/base/ziputil.h
@@ -40,10 +40,6 @@ class ZipUtil : public ArchiveUtil
         qint64 totalUncompressedSize(unsigned int clustersize = 0);
         virtual QStringList files(void);
 
-    signals:
-       void logProgress(int, int);
-       void logItem(QString, int);
-
     private:
         QList<QuaZipFileInfo> contentProperties();
         QuaZip* m_zip;
-- 
cgit v1.2.3