summaryrefslogtreecommitdiff
path: root/firmware/target/mips/ingenic_x1000/sfc-x1000.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2021-06-05 00:12:01 +0100
committerAidan MacDonald <amachronic@protonmail.com>2021-06-06 11:06:14 +0000
commite85bc74b307365e9a7b4adab51d646638db12fbd (patch)
treec45ba9079344b5cc0ea48a77b6aa77aacd71cdc5 /firmware/target/mips/ingenic_x1000/sfc-x1000.c
parent695d1701cdd1bb4539f652c2204f7787097b2715 (diff)
downloadrockbox-e85bc74b307365e9a7b4adab51d646638db12fbd.tar.gz
rockbox-e85bc74b307365e9a7b4adab51d646638db12fbd.zip
x1000: GPIO refactor
The GPIO API was pretty clunky and pin settings were decentralized, making it hard to see what was happening and making GPIO stuff look like a mess, frankly. Instead of passing clunky (port, pin) pairs everywhere, GPIOs are now identified with a single int. The extra overhead should be minimal as GPIO configuration is generally not on a performance-critical path. Pin assignments are now mostly consolidated in gpio-target.h and put in various tables so gpio_init() can assign most pins at boot time. Most drivers no longer need to touch GPIOs and basic pin I/O stuff can happen without config since pins are put into the right state. IRQ pins still need to be configured manually before use. Change-Id: Ic5326284b0b2a2f613e9e76a41cb50e24af3aa47
Diffstat (limited to 'firmware/target/mips/ingenic_x1000/sfc-x1000.c')
-rw-r--r--firmware/target/mips/ingenic_x1000/sfc-x1000.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/firmware/target/mips/ingenic_x1000/sfc-x1000.c b/firmware/target/mips/ingenic_x1000/sfc-x1000.c
index 3f1cb25f07..c1ffb6a5e1 100644
--- a/firmware/target/mips/ingenic_x1000/sfc-x1000.c
+++ b/firmware/target/mips/ingenic_x1000/sfc-x1000.c
@@ -23,7 +23,6 @@
23#include "kernel.h" 23#include "kernel.h"
24#include "panic.h" 24#include "panic.h"
25#include "sfc-x1000.h" 25#include "sfc-x1000.h"
26#include "gpio-x1000.h"
27#include "irq-x1000.h" 26#include "irq-x1000.h"
28#include "x1000/sfc.h" 27#include "x1000/sfc.h"
29#include "x1000/cpm.h" 28#include "x1000/cpm.h"
@@ -75,7 +74,6 @@ void sfc_unlock(void)
75 74
76void sfc_open(void) 75void sfc_open(void)
77{ 76{
78 gpio_config(GPIO_A, 0x3f << 26, GPIO_DEVICE(1));
79 jz_writef(CPM_CLKGR, SFC(0)); 77 jz_writef(CPM_CLKGR, SFC(0));
80 jz_writef(SFC_GLB, OP_MODE_V(SLAVE), PHASE_NUM(1), 78 jz_writef(SFC_GLB, OP_MODE_V(SLAVE), PHASE_NUM(1),
81 THRESHOLD(FIFO_THRESH), WP_EN(1)); 79 THRESHOLD(FIFO_THRESH), WP_EN(1));