diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/export/config | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/export/config')
-rw-r--r-- | firmware/export/config/gigabeats.h | 2 | ||||
-rw-r--r-- | firmware/export/config/ipod4g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipod6g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodcolor.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodmini1g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodmini2g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodnano1g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodnano2g.h | 1 | ||||
-rw-r--r-- | firmware/export/config/ipodvideo.h | 1 |
9 files changed, 9 insertions, 1 deletions
diff --git a/firmware/export/config/gigabeats.h b/firmware/export/config/gigabeats.h index e1bbb18529..928e8c0e60 100644 --- a/firmware/export/config/gigabeats.h +++ b/firmware/export/config/gigabeats.h | |||
@@ -121,7 +121,7 @@ | |||
121 | /* Define this if you have a SI4700 fm radio tuner */ | 121 | /* Define this if you have a SI4700 fm radio tuner */ |
122 | #define CONFIG_TUNER SI4700 | 122 | #define CONFIG_TUNER SI4700 |
123 | #define HAVE_RDS_CAP | 123 | #define HAVE_RDS_CAP |
124 | #define RDS_ISR_PROCESSING | 124 | #define CONFIG_RDS (RDS_CFG_ISR | RDS_CFG_PROCESS) |
125 | 125 | ||
126 | /* define this if you can flip your LCD */ | 126 | /* define this if you can flip your LCD */ |
127 | #define HAVE_LCD_FLIP | 127 | #define HAVE_LCD_FLIP |
diff --git a/firmware/export/config/ipod4g.h b/firmware/export/config/ipod4g.h index dc83a594fc..785491a9ab 100644 --- a/firmware/export/config/ipod4g.h +++ b/firmware/export/config/ipod4g.h | |||
@@ -164,6 +164,7 @@ | |||
164 | /* Define Apple remote tuner */ | 164 | /* Define Apple remote tuner */ |
165 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 165 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
166 | #define HAVE_RDS_CAP | 166 | #define HAVE_RDS_CAP |
167 | #define CONFIG_RDS RDS_CFG_PUSH | ||
167 | 168 | ||
168 | /* Define this if you have a PortalPlayer PP5020 */ | 169 | /* Define this if you have a PortalPlayer PP5020 */ |
169 | #define CONFIG_CPU PP5020 | 170 | #define CONFIG_CPU PP5020 |
diff --git a/firmware/export/config/ipod6g.h b/firmware/export/config/ipod6g.h index 5494cf387a..7664fd4f90 100644 --- a/firmware/export/config/ipod6g.h +++ b/firmware/export/config/ipod6g.h | |||
@@ -167,6 +167,7 @@ | |||
167 | /* Define Apple remote tuner */ | 167 | /* Define Apple remote tuner */ |
168 | //#define CONFIG_TUNER IPOD_REMOTE_TUNER | 168 | //#define CONFIG_TUNER IPOD_REMOTE_TUNER |
169 | //#define HAVE_RDS_CAP | 169 | //#define HAVE_RDS_CAP |
170 | //#define CONFIG_RDS RDS_CFG_PUSH | ||
170 | 171 | ||
171 | /* The exact type of CPU */ | 172 | /* The exact type of CPU */ |
172 | #define CONFIG_CPU S5L8702 | 173 | #define CONFIG_CPU S5L8702 |
diff --git a/firmware/export/config/ipodcolor.h b/firmware/export/config/ipodcolor.h index 9f34a7955b..33533f925f 100644 --- a/firmware/export/config/ipodcolor.h +++ b/firmware/export/config/ipodcolor.h | |||
@@ -151,6 +151,7 @@ | |||
151 | /* Define Apple remote tuner */ | 151 | /* Define Apple remote tuner */ |
152 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 152 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
153 | #define HAVE_RDS_CAP | 153 | #define HAVE_RDS_CAP |
154 | #define CONFIG_RDS RDS_CFG_PUSH | ||
154 | 155 | ||
155 | /* Define this if you have a PortalPlayer PP5020 */ | 156 | /* Define this if you have a PortalPlayer PP5020 */ |
156 | #define CONFIG_CPU PP5020 | 157 | #define CONFIG_CPU PP5020 |
diff --git a/firmware/export/config/ipodmini1g.h b/firmware/export/config/ipodmini1g.h index 71dfe16c04..4f9f1b3dd9 100644 --- a/firmware/export/config/ipodmini1g.h +++ b/firmware/export/config/ipodmini1g.h | |||
@@ -163,6 +163,7 @@ | |||
163 | /* Define Apple remote tuner */ | 163 | /* Define Apple remote tuner */ |
164 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 164 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
165 | #define HAVE_RDS_CAP | 165 | #define HAVE_RDS_CAP |
166 | #define CONFIG_RDS RDS_CFG_PUSH | ||
166 | 167 | ||
167 | /* Define this if you have a PortalPlayer PP5020 */ | 168 | /* Define this if you have a PortalPlayer PP5020 */ |
168 | #define CONFIG_CPU PP5020 | 169 | #define CONFIG_CPU PP5020 |
diff --git a/firmware/export/config/ipodmini2g.h b/firmware/export/config/ipodmini2g.h index a2b199afee..977eb3da3f 100644 --- a/firmware/export/config/ipodmini2g.h +++ b/firmware/export/config/ipodmini2g.h | |||
@@ -164,6 +164,7 @@ | |||
164 | /* Define Apple remote tuner */ | 164 | /* Define Apple remote tuner */ |
165 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 165 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
166 | #define HAVE_RDS_CAP | 166 | #define HAVE_RDS_CAP |
167 | #define CONFIG_RDS RDS_CFG_PUSH | ||
167 | 168 | ||
168 | /* Define this if you have a PortalPlayer PP5022 */ | 169 | /* Define this if you have a PortalPlayer PP5022 */ |
169 | #define CONFIG_CPU PP5022 | 170 | #define CONFIG_CPU PP5022 |
diff --git a/firmware/export/config/ipodnano1g.h b/firmware/export/config/ipodnano1g.h index acdfff3c15..81d4a0ae4c 100644 --- a/firmware/export/config/ipodnano1g.h +++ b/firmware/export/config/ipodnano1g.h | |||
@@ -154,6 +154,7 @@ | |||
154 | /* Define Apple remote tuner */ | 154 | /* Define Apple remote tuner */ |
155 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 155 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
156 | #define HAVE_RDS_CAP | 156 | #define HAVE_RDS_CAP |
157 | #define CONFIG_RDS RDS_CFG_PUSH | ||
157 | 158 | ||
158 | /* Define this if you have a PortalPlayer PP5022 */ | 159 | /* Define this if you have a PortalPlayer PP5022 */ |
159 | #define CONFIG_CPU PP5022 | 160 | #define CONFIG_CPU PP5022 |
diff --git a/firmware/export/config/ipodnano2g.h b/firmware/export/config/ipodnano2g.h index aeff6aeda1..9d8c39ef7e 100644 --- a/firmware/export/config/ipodnano2g.h +++ b/firmware/export/config/ipodnano2g.h | |||
@@ -164,6 +164,7 @@ | |||
164 | /* Define Apple remote tuner */ | 164 | /* Define Apple remote tuner */ |
165 | //#define CONFIG_TUNER IPOD_REMOTE_TUNER | 165 | //#define CONFIG_TUNER IPOD_REMOTE_TUNER |
166 | //#define HAVE_RDS_CAP | 166 | //#define HAVE_RDS_CAP |
167 | //#define CONFIG_RDS RDS_CFG_PUSH | ||
167 | 168 | ||
168 | /* The exact type of CPU */ | 169 | /* The exact type of CPU */ |
169 | #define CONFIG_CPU S5L8701 | 170 | #define CONFIG_CPU S5L8701 |
diff --git a/firmware/export/config/ipodvideo.h b/firmware/export/config/ipodvideo.h index 2f28182731..7f1d83f4a5 100644 --- a/firmware/export/config/ipodvideo.h +++ b/firmware/export/config/ipodvideo.h | |||
@@ -170,6 +170,7 @@ | |||
170 | /* Define Apple remote tuner */ | 170 | /* Define Apple remote tuner */ |
171 | #define CONFIG_TUNER IPOD_REMOTE_TUNER | 171 | #define CONFIG_TUNER IPOD_REMOTE_TUNER |
172 | #define HAVE_RDS_CAP | 172 | #define HAVE_RDS_CAP |
173 | #define CONFIG_RDS RDS_CFG_PUSH | ||
173 | 174 | ||
174 | /* Define this if you have a PortalPlayer PP5022 */ | 175 | /* Define this if you have a PortalPlayer PP5022 */ |
175 | #define CONFIG_CPU PP5022 | 176 | #define CONFIG_CPU PP5022 |