From fc9695eb47732e1c189e2f033dbd55e5c346e8c4 Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Mon, 30 Jan 2017 09:52:05 -0500 Subject: Improve radio RDS driver and framework * Remove unused bits like the radio event and simplify basic radio interface. It can be more self-contained with rds.h only required by radio and tuner code. * Add post-processing to text a-la Silicon Labs AN243. The chip's error correction can only do so much; additional checks are highly recommended. Simply testing for two identical messages in a row is extremely effective and I've never seen corrupted text since doing that, even with mediocre reception. Groups segments must arrive in order, not randomly; logic change only accepts them in order, starting at 0. Time readout was made a bit better but really we'd need to use verbose mode and ensure that no errors were seen during receiving of time and more checks would be need to have a stable PI. The text is the important bit anyway. * Time out of stale text. * Text is no longer updated until a complete group has been received, as is specified in the standard. Perhaps go back to scrolling text lines in the radio screen? * Add proper character conversion to UTF-8. Only the default G0 table for the moment. The other two could be added in. * Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow the option for processed RDS data to be pushed to the driver and still do proper post-processing (only text conversion for now for the latter). Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925 --- firmware/export/config/gigabeats.h | 2 +- firmware/export/config/ipod4g.h | 1 + firmware/export/config/ipod6g.h | 1 + firmware/export/config/ipodcolor.h | 1 + firmware/export/config/ipodmini1g.h | 1 + firmware/export/config/ipodmini2g.h | 1 + firmware/export/config/ipodnano1g.h | 1 + firmware/export/config/ipodnano2g.h | 1 + firmware/export/config/ipodvideo.h | 1 + 9 files changed, 9 insertions(+), 1 deletion(-) (limited to 'firmware/export/config') diff --git a/firmware/export/config/gigabeats.h b/firmware/export/config/gigabeats.h index e1bbb18529..928e8c0e60 100644 --- a/firmware/export/config/gigabeats.h +++ b/firmware/export/config/gigabeats.h @@ -121,7 +121,7 @@ /* Define this if you have a SI4700 fm radio tuner */ #define CONFIG_TUNER SI4700 #define HAVE_RDS_CAP -#define RDS_ISR_PROCESSING +#define CONFIG_RDS (RDS_CFG_ISR | RDS_CFG_PROCESS) /* define this if you can flip your LCD */ #define HAVE_LCD_FLIP diff --git a/firmware/export/config/ipod4g.h b/firmware/export/config/ipod4g.h index dc83a594fc..785491a9ab 100644 --- a/firmware/export/config/ipod4g.h +++ b/firmware/export/config/ipod4g.h @@ -164,6 +164,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5020 */ #define CONFIG_CPU PP5020 diff --git a/firmware/export/config/ipod6g.h b/firmware/export/config/ipod6g.h index 5494cf387a..7664fd4f90 100644 --- a/firmware/export/config/ipod6g.h +++ b/firmware/export/config/ipod6g.h @@ -167,6 +167,7 @@ /* Define Apple remote tuner */ //#define CONFIG_TUNER IPOD_REMOTE_TUNER //#define HAVE_RDS_CAP +//#define CONFIG_RDS RDS_CFG_PUSH /* The exact type of CPU */ #define CONFIG_CPU S5L8702 diff --git a/firmware/export/config/ipodcolor.h b/firmware/export/config/ipodcolor.h index 9f34a7955b..33533f925f 100644 --- a/firmware/export/config/ipodcolor.h +++ b/firmware/export/config/ipodcolor.h @@ -151,6 +151,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5020 */ #define CONFIG_CPU PP5020 diff --git a/firmware/export/config/ipodmini1g.h b/firmware/export/config/ipodmini1g.h index 71dfe16c04..4f9f1b3dd9 100644 --- a/firmware/export/config/ipodmini1g.h +++ b/firmware/export/config/ipodmini1g.h @@ -163,6 +163,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5020 */ #define CONFIG_CPU PP5020 diff --git a/firmware/export/config/ipodmini2g.h b/firmware/export/config/ipodmini2g.h index a2b199afee..977eb3da3f 100644 --- a/firmware/export/config/ipodmini2g.h +++ b/firmware/export/config/ipodmini2g.h @@ -164,6 +164,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5022 */ #define CONFIG_CPU PP5022 diff --git a/firmware/export/config/ipodnano1g.h b/firmware/export/config/ipodnano1g.h index acdfff3c15..81d4a0ae4c 100644 --- a/firmware/export/config/ipodnano1g.h +++ b/firmware/export/config/ipodnano1g.h @@ -154,6 +154,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5022 */ #define CONFIG_CPU PP5022 diff --git a/firmware/export/config/ipodnano2g.h b/firmware/export/config/ipodnano2g.h index aeff6aeda1..9d8c39ef7e 100644 --- a/firmware/export/config/ipodnano2g.h +++ b/firmware/export/config/ipodnano2g.h @@ -164,6 +164,7 @@ /* Define Apple remote tuner */ //#define CONFIG_TUNER IPOD_REMOTE_TUNER //#define HAVE_RDS_CAP +//#define CONFIG_RDS RDS_CFG_PUSH /* The exact type of CPU */ #define CONFIG_CPU S5L8701 diff --git a/firmware/export/config/ipodvideo.h b/firmware/export/config/ipodvideo.h index 2f28182731..7f1d83f4a5 100644 --- a/firmware/export/config/ipodvideo.h +++ b/firmware/export/config/ipodvideo.h @@ -170,6 +170,7 @@ /* Define Apple remote tuner */ #define CONFIG_TUNER IPOD_REMOTE_TUNER #define HAVE_RDS_CAP +#define CONFIG_RDS RDS_CFG_PUSH /* Define this if you have a PortalPlayer PP5022 */ #define CONFIG_CPU PP5022 -- cgit v1.2.3