summaryrefslogtreecommitdiff
path: root/firmware/drivers/m66591.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2021-09-19 10:54:26 +0100
committerAidan MacDonald <amachronic@protonmail.com>2021-09-20 22:41:29 +0100
commit672bbe434b12d4730cf270f7245753fb98cf162d (patch)
tree3fdaa08ddc41f942336c968bb169e8806c7c3fa8 /firmware/drivers/m66591.c
parent99f333c64f13c3f9a62b9f5e184ae87f053bf65a (diff)
downloadrockbox-672bbe434b12d4730cf270f7245753fb98cf162d.tar.gz
rockbox-672bbe434b12d4730cf270f7245753fb98cf162d.zip
usb: rename usb_drv_recv() to usb_recv_recv_nonblocking()
IMHO the current name is somewhat misleading: - usb_drv_send() is blocking and we have usb_drv_send_nonblocking() for the non-blocking case. This inconsistent naming can only promote confusion. (And what would we call a blocking receive?) - Other hardware abstraction APIs in Rockbox are usually blocking: storage, LCD, backlight, audio... in other words, blocking is the default expected behavior, with non-blocking calls being a rarity. Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af
Diffstat (limited to 'firmware/drivers/m66591.c')
-rw-r--r--firmware/drivers/m66591.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/firmware/drivers/m66591.c b/firmware/drivers/m66591.c
index d09b269f33..5da1908290 100644
--- a/firmware/drivers/m66591.c
+++ b/firmware/drivers/m66591.c
@@ -869,7 +869,7 @@ int usb_drv_send(int endpoint, void* ptr, int length)
869/* This function begins a receive (on an OUT endpoint), it should not block 869/* This function begins a receive (on an OUT endpoint), it should not block
870 * so the actual receive is done in the interrupt handler. 870 * so the actual receive is done in the interrupt handler.
871 */ 871 */
872int usb_drv_recv(int endpoint, void* ptr, int length) 872int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length)
873{ 873{
874 return mxx_queue(endpoint, ptr, length, false, false); 874 return mxx_queue(endpoint, ptr, length, false, false);
875} 875}