From 672bbe434b12d4730cf270f7245753fb98cf162d Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sun, 19 Sep 2021 10:54:26 +0100 Subject: usb: rename usb_drv_recv() to usb_recv_recv_nonblocking() IMHO the current name is somewhat misleading: - usb_drv_send() is blocking and we have usb_drv_send_nonblocking() for the non-blocking case. This inconsistent naming can only promote confusion. (And what would we call a blocking receive?) - Other hardware abstraction APIs in Rockbox are usually blocking: storage, LCD, backlight, audio... in other words, blocking is the default expected behavior, with non-blocking calls being a rarity. Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af --- firmware/drivers/m66591.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'firmware/drivers/m66591.c') diff --git a/firmware/drivers/m66591.c b/firmware/drivers/m66591.c index d09b269f33..5da1908290 100644 --- a/firmware/drivers/m66591.c +++ b/firmware/drivers/m66591.c @@ -869,7 +869,7 @@ int usb_drv_send(int endpoint, void* ptr, int length) /* This function begins a receive (on an OUT endpoint), it should not block * so the actual receive is done in the interrupt handler. */ -int usb_drv_recv(int endpoint, void* ptr, int length) +int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length) { return mxx_queue(endpoint, ptr, length, false, false); } -- cgit v1.2.3