diff options
| author | Thomas Jarosch <tomj@simonv.com> | 2014-12-20 12:27:38 +0100 |
|---|---|---|
| committer | Thomas Jarosch <tomj@simonv.com> | 2014-12-20 12:33:26 +0100 |
| commit | 1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055 (patch) | |
| tree | c5e7de2543860fc790dbb7be7452e4e2bde5abc9 /apps | |
| parent | c55be3b83ae2e23754a93ee8676d76604c0a5f8e (diff) | |
| download | rockbox-1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055.tar.gz rockbox-1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055.zip | |
Fix broken buflib_handle check in backdrop settings loader
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.
Thanks to JdGordon for verifying the change.
cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.
Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/gui/skin_engine/skin_backdrops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/gui/skin_engine/skin_backdrops.c b/apps/gui/skin_engine/skin_backdrops.c index 8962b5113f..243fc30a3a 100644 --- a/apps/gui/skin_engine/skin_backdrops.c +++ b/apps/gui/skin_engine/skin_backdrops.c | |||
| @@ -259,7 +259,7 @@ void skin_backdrop_load_setting(void) | |||
| 259 | if (global_settings.backdrop_file[0] && | 259 | if (global_settings.backdrop_file[0] && |
| 260 | global_settings.backdrop_file[0] != '-') | 260 | global_settings.backdrop_file[0] != '-') |
| 261 | { | 261 | { |
| 262 | if (!backdrops[i].buflib_handle <= 0) | 262 | if (backdrops[i].buflib_handle <= 0) |
| 263 | { | 263 | { |
| 264 | backdrops[i].buflib_handle = | 264 | backdrops[i].buflib_handle = |
| 265 | core_alloc_ex(global_settings.backdrop_file, | 265 | core_alloc_ex(global_settings.backdrop_file, |