From 1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055 Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Sat, 20 Dec 2014 12:27:38 +0100 Subject: Fix broken buflib_handle check in backdrop settings loader The logic was messed up and always evaluated to true if buflib_handle is non-zero. Thanks to JdGordon for verifying the change. cppcheck reported: [rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1. Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83 --- apps/gui/skin_engine/skin_backdrops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'apps') diff --git a/apps/gui/skin_engine/skin_backdrops.c b/apps/gui/skin_engine/skin_backdrops.c index 8962b5113f..243fc30a3a 100644 --- a/apps/gui/skin_engine/skin_backdrops.c +++ b/apps/gui/skin_engine/skin_backdrops.c @@ -259,7 +259,7 @@ void skin_backdrop_load_setting(void) if (global_settings.backdrop_file[0] && global_settings.backdrop_file[0] != '-') { - if (!backdrops[i].buflib_handle <= 0) + if (backdrops[i].buflib_handle <= 0) { backdrops[i].buflib_handle = core_alloc_ex(global_settings.backdrop_file, -- cgit v1.2.3