diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 11:38:09 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 10:22:55 -0400 |
commit | ead172c05d57568d201709c5fac77cbb8982bbd0 (patch) | |
tree | 10ab4de5bafb8092d1b1a3cd27ca8680cf650def /apps/settings_list.c | |
parent | fe6aa21e9eb88f49005863efd2003d0982920048 (diff) | |
download | rockbox-ead172c05d57568d201709c5fac77cbb8982bbd0.tar.gz rockbox-ead172c05d57568d201709c5fac77cbb8982bbd0.zip |
gui: Remove redundant copies of list scrolling settings
gui_list_screen_scroll_step() and gui_list_screen_scroll_out_of_view()
just copy the global setting into a local static variable.
Since they don't do anything special when the setting changes
it's simpler to use the global setting directly.
Change-Id: Ib6a7bf4e09b6dabbc1597cf28ddbafc0bc857526
Diffstat (limited to 'apps/settings_list.c')
-rw-r--r-- | apps/settings_list.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/apps/settings_list.c b/apps/settings_list.c index 699afb92fd..6d01f5c6fc 100644 --- a/apps/settings_list.c +++ b/apps/settings_list.c | |||
@@ -1227,13 +1227,11 @@ const struct settings_list settings[] = { | |||
1227 | lcd_remote_bidir_scroll), | 1227 | lcd_remote_bidir_scroll), |
1228 | #endif | 1228 | #endif |
1229 | OFFON_SETTING(0, offset_out_of_view, LANG_SCREEN_SCROLL_VIEW, | 1229 | OFFON_SETTING(0, offset_out_of_view, LANG_SCREEN_SCROLL_VIEW, |
1230 | false, "Screen Scrolls Out Of View", | 1230 | false, "Screen Scrolls Out Of View", NULL), |
1231 | gui_list_screen_scroll_out_of_view), | ||
1232 | INT_SETTING(F_PADTITLE, scroll_step, LANG_SCROLL_STEP, 6, "scroll step", | 1231 | INT_SETTING(F_PADTITLE, scroll_step, LANG_SCROLL_STEP, 6, "scroll step", |
1233 | UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, lcd_scroll_step), | 1232 | UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, lcd_scroll_step), |
1234 | INT_SETTING(F_PADTITLE, screen_scroll_step, LANG_SCREEN_SCROLL_STEP, 16, | 1233 | INT_SETTING(F_PADTITLE, screen_scroll_step, LANG_SCREEN_SCROLL_STEP, 16, |
1235 | "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, | 1234 | "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, NULL), |
1236 | gui_list_screen_scroll_step), | ||
1237 | OFFON_SETTING(0,scroll_paginated,LANG_SCROLL_PAGINATED, | 1235 | OFFON_SETTING(0,scroll_paginated,LANG_SCROLL_PAGINATED, |
1238 | false,"scroll paginated",NULL), | 1236 | false,"scroll paginated",NULL), |
1239 | OFFON_SETTING(0,list_wraparound,LANG_LIST_WRAPAROUND, | 1237 | OFFON_SETTING(0,list_wraparound,LANG_LIST_WRAPAROUND, |