From ead172c05d57568d201709c5fac77cbb8982bbd0 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Mon, 19 Sep 2022 11:38:09 +0100 Subject: gui: Remove redundant copies of list scrolling settings gui_list_screen_scroll_step() and gui_list_screen_scroll_out_of_view() just copy the global setting into a local static variable. Since they don't do anything special when the setting changes it's simpler to use the global setting directly. Change-Id: Ib6a7bf4e09b6dabbc1597cf28ddbafc0bc857526 --- apps/settings_list.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'apps/settings_list.c') diff --git a/apps/settings_list.c b/apps/settings_list.c index 699afb92fd..6d01f5c6fc 100644 --- a/apps/settings_list.c +++ b/apps/settings_list.c @@ -1227,13 +1227,11 @@ const struct settings_list settings[] = { lcd_remote_bidir_scroll), #endif OFFON_SETTING(0, offset_out_of_view, LANG_SCREEN_SCROLL_VIEW, - false, "Screen Scrolls Out Of View", - gui_list_screen_scroll_out_of_view), + false, "Screen Scrolls Out Of View", NULL), INT_SETTING(F_PADTITLE, scroll_step, LANG_SCROLL_STEP, 6, "scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, lcd_scroll_step), INT_SETTING(F_PADTITLE, screen_scroll_step, LANG_SCREEN_SCROLL_STEP, 16, - "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, - gui_list_screen_scroll_step), + "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, NULL), OFFON_SETTING(0,scroll_paginated,LANG_SCROLL_PAGINATED, false,"scroll paginated",NULL), OFFON_SETTING(0,list_wraparound,LANG_LIST_WRAPAROUND, -- cgit v1.2.3