diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 11:10:54 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-02 09:21:25 -0400 |
commit | 9ce5b2a2eda5c7101898476adaa3533e0ba5db82 (patch) | |
tree | facbfe9721d907b1a92f2b113b262374c6e2917e /apps/plugin.c | |
parent | c1d75a6bcb30260eba288f643261c4a57959f45f (diff) | |
download | rockbox-9ce5b2a2eda5c7101898476adaa3533e0ba5db82.tar.gz rockbox-9ce5b2a2eda5c7101898476adaa3533e0ba5db82.zip |
gui: Remove show/hide selection option in lists
The implementation of the "show_selection_marker" option in
lists isn't great. It's a cosmetic option used to hide the
selection, but it causes the list to do funny things to the
selected_item and doesn't play nice with voiced menus, since
these rely on the selection to determine what item is spoken.
There are only two user-facing lists that use the option, the
"Rockbox Info" screen and a menu in the superdom plugin. The
rest are debug screens, and cosmetics don't matter much there.
Given how little used the option is, and its issues, removing
it seems reasonable.
Change-Id: I2c70b3e4c74ff3cc6dbac46366a371d271dd2d58
Diffstat (limited to 'apps/plugin.c')
-rw-r--r-- | apps/plugin.c | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/apps/plugin.c b/apps/plugin.c index eb76eb7753..42965bc581 100644 --- a/apps/plugin.c +++ b/apps/plugin.c | |||
@@ -357,6 +357,7 @@ static const struct plugin_api rockbox_api = { | |||
357 | action_get_touchscreen_press_in_vp, | 357 | action_get_touchscreen_press_in_vp, |
358 | #endif | 358 | #endif |
359 | action_userabort, | 359 | action_userabort, |
360 | core_set_keyremap, | ||
360 | 361 | ||
361 | /* button */ | 362 | /* button */ |
362 | button_get, | 363 | button_get, |
@@ -436,6 +437,8 @@ static const struct plugin_api rockbox_api = { | |||
436 | tree_get_entry_at, | 437 | tree_get_entry_at, |
437 | set_current_file, | 438 | set_current_file, |
438 | set_dirfilter, | 439 | set_dirfilter, |
440 | onplay_show_playlist_menu, | ||
441 | browse_id3, | ||
439 | 442 | ||
440 | /* talking */ | 443 | /* talking */ |
441 | talk_id, | 444 | talk_id, |
@@ -519,6 +522,7 @@ static const struct plugin_api rockbox_api = { | |||
519 | queue_wait, | 522 | queue_wait, |
520 | queue_send, | 523 | queue_send, |
521 | queue_reply, | 524 | queue_reply, |
525 | queue_remove_from_head, | ||
522 | 526 | ||
523 | #ifdef RB_PROFILE | 527 | #ifdef RB_PROFILE |
524 | profile_thread, | 528 | profile_thread, |
@@ -688,7 +692,9 @@ static const struct plugin_api rockbox_api = { | |||
688 | playlist_create, | 692 | playlist_create, |
689 | playlist_insert_track, | 693 | playlist_insert_track, |
690 | playlist_insert_directory, | 694 | playlist_insert_directory, |
695 | playlist_insert_playlist, | ||
691 | playlist_shuffle, | 696 | playlist_shuffle, |
697 | warn_on_pl_erase, | ||
692 | audio_play, | 698 | audio_play, |
693 | audio_stop, | 699 | audio_stop, |
694 | audio_pause, | 700 | audio_pause, |
@@ -731,6 +737,7 @@ static const struct plugin_api rockbox_api = { | |||
731 | battery_level_safe, | 737 | battery_level_safe, |
732 | battery_time, | 738 | battery_time, |
733 | battery_voltage, | 739 | battery_voltage, |
740 | battery_current, | ||
734 | #if CONFIG_CHARGING | 741 | #if CONFIG_CHARGING |
735 | charger_inserted, | 742 | charger_inserted, |
736 | # if CONFIG_CHARGING >= CHARGING_MONITOR | 743 | # if CONFIG_CHARGING >= CHARGING_MONITOR |
@@ -801,21 +808,19 @@ static const struct plugin_api rockbox_api = { | |||
801 | plugin_release_audio_buffer, /* defined in plugin.c */ | 808 | plugin_release_audio_buffer, /* defined in plugin.c */ |
802 | plugin_tsr, /* defined in plugin.c */ | 809 | plugin_tsr, /* defined in plugin.c */ |
803 | plugin_get_current_filename, | 810 | plugin_get_current_filename, |
804 | /* new stuff at the end, sort into place next time | ||
805 | the API gets incompatible */ | ||
806 | warn_on_pl_erase, | ||
807 | playlist_insert_playlist, | ||
808 | battery_current, | ||
809 | onplay_show_playlist_menu, | ||
810 | queue_remove_from_head, | ||
811 | core_set_keyremap, | ||
812 | plugin_reserve_buffer, | 811 | plugin_reserve_buffer, |
812 | |||
813 | /* reboot and poweroff */ | ||
814 | sys_poweroff, | ||
815 | sys_reboot, | ||
816 | |||
817 | /* pathfuncs */ | ||
813 | #ifdef HAVE_MULTIVOLUME | 818 | #ifdef HAVE_MULTIVOLUME |
814 | path_strip_volume, | 819 | path_strip_volume, |
815 | #endif | 820 | #endif |
816 | sys_poweroff, | 821 | |
817 | sys_reboot, | 822 | /* new stuff at the end, sort into place next time |
818 | browse_id3, | 823 | the API gets incompatible */ |
819 | }; | 824 | }; |
820 | 825 | ||
821 | static int plugin_buffer_handle; | 826 | static int plugin_buffer_handle; |