From 9ce5b2a2eda5c7101898476adaa3533e0ba5db82 Mon Sep 17 00:00:00 2001
From: Aidan MacDonald <amachronic@protonmail.com>
Date: Mon, 19 Sep 2022 11:10:54 +0100
Subject: gui: Remove show/hide selection option in lists

The implementation of the "show_selection_marker" option in
lists isn't great. It's a cosmetic option used to hide the
selection, but it causes the list to do funny things to the
selected_item and doesn't play nice with voiced menus, since
these rely on the selection to determine what item is spoken.

There are only two user-facing lists that use the option, the
"Rockbox Info" screen and a menu in the superdom plugin. The
rest are debug screens, and cosmetics don't matter much there.

Given how little used the option is, and its issues, removing
it seems reasonable.

Change-Id: I2c70b3e4c74ff3cc6dbac46366a371d271dd2d58
---
 apps/plugin.c | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

(limited to 'apps/plugin.c')

diff --git a/apps/plugin.c b/apps/plugin.c
index eb76eb7753..42965bc581 100644
--- a/apps/plugin.c
+++ b/apps/plugin.c
@@ -357,6 +357,7 @@ static const struct plugin_api rockbox_api = {
     action_get_touchscreen_press_in_vp,
 #endif
     action_userabort,
+    core_set_keyremap,
 
     /* button */
     button_get,
@@ -436,6 +437,8 @@ static const struct plugin_api rockbox_api = {
     tree_get_entry_at,
     set_current_file,
     set_dirfilter,
+    onplay_show_playlist_menu,
+    browse_id3,
 
     /* talking */
     talk_id,
@@ -519,6 +522,7 @@ static const struct plugin_api rockbox_api = {
     queue_wait,
     queue_send,
     queue_reply,
+    queue_remove_from_head,
 
 #ifdef RB_PROFILE
     profile_thread,
@@ -688,7 +692,9 @@ static const struct plugin_api rockbox_api = {
     playlist_create,
     playlist_insert_track,
     playlist_insert_directory,
+    playlist_insert_playlist,
     playlist_shuffle,
+    warn_on_pl_erase,
     audio_play,
     audio_stop,
     audio_pause,
@@ -731,6 +737,7 @@ static const struct plugin_api rockbox_api = {
     battery_level_safe,
     battery_time,
     battery_voltage,
+    battery_current,
 #if CONFIG_CHARGING
     charger_inserted,
 # if CONFIG_CHARGING >= CHARGING_MONITOR
@@ -801,21 +808,19 @@ static const struct plugin_api rockbox_api = {
     plugin_release_audio_buffer, /* defined in plugin.c */
     plugin_tsr,                  /* defined in plugin.c */
     plugin_get_current_filename,
-    /* new stuff at the end, sort into place next time
-       the API gets incompatible */
-    warn_on_pl_erase,
-    playlist_insert_playlist,
-    battery_current,
-    onplay_show_playlist_menu,
-    queue_remove_from_head,
-    core_set_keyremap,
     plugin_reserve_buffer,
+
+    /* reboot and poweroff */
+    sys_poweroff,
+    sys_reboot,
+
+    /* pathfuncs */
 #ifdef HAVE_MULTIVOLUME
     path_strip_volume,
 #endif
-    sys_poweroff,
-    sys_reboot,
-    browse_id3,
+
+    /* new stuff at the end, sort into place next time
+       the API gets incompatible */
 };
 
 static int plugin_buffer_handle;
-- 
cgit v1.2.3