summaryrefslogtreecommitdiff
path: root/apps/playback.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-03-26 21:54:23 +0000
committerSolomon Peachy <pizza@shaftnet.org>2022-04-20 16:51:49 -0400
commit9e93796407ecb8a347f9799c0a03e80939004bd7 (patch)
treeaf70eab0998907aa34602c9345115a60a03f0b4a /apps/playback.c
parent931d61607174ad1b09f9725ec9da214b63daed85 (diff)
downloadrockbox-9e93796407ecb8a347f9799c0a03e80939004bd7.tar.gz
rockbox-9e93796407ecb8a347f9799c0a03e80939004bd7.zip
buffering: remove bufgettail/bufcuttail
These operations can only be used in limited circumstances and have exactly one user. bufgettail especially seems of dubious value; how often do you need to read N bytes from the end of a file without changing the file position? strip_tags() was the only function using them, to strip off ID3v1 and APE tags off the end of buffered tracks. This would save only 32-192 bytes per track -- if the container format uses APE/ID3v1. It hardly seems worth the effort. Change-Id: I8fc3c1408517eda6126e75e76d76daea904b50eb
Diffstat (limited to 'apps/playback.c')
-rw-r--r--apps/playback.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/apps/playback.c b/apps/playback.c
index a56c6d17ec..7fdb302d71 100644
--- a/apps/playback.c
+++ b/apps/playback.c
@@ -3467,9 +3467,6 @@ static void buffer_event_finished_callback(unsigned short id, void *ev_data)
3467 break; 3467 break;
3468 3468
3469 case TYPE_PACKET_AUDIO: 3469 case TYPE_PACKET_AUDIO:
3470 /* Strip any useless trailing tags that are left. */
3471 strip_tags(hid);
3472 /* Fall-through */
3473 case TYPE_ATOMIC_AUDIO: 3470 case TYPE_ATOMIC_AUDIO:
3474 LOGFQUEUE("buffering > audio Q_AUDIO_HANDLE_FINISHED: %d", hid); 3471 LOGFQUEUE("buffering > audio Q_AUDIO_HANDLE_FINISHED: %d", hid);
3475 audio_queue_post(Q_AUDIO_HANDLE_FINISHED, hid); 3472 audio_queue_post(Q_AUDIO_HANDLE_FINISHED, hid);