From 9e93796407ecb8a347f9799c0a03e80939004bd7 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sat, 26 Mar 2022 21:54:23 +0000 Subject: buffering: remove bufgettail/bufcuttail These operations can only be used in limited circumstances and have exactly one user. bufgettail especially seems of dubious value; how often do you need to read N bytes from the end of a file without changing the file position? strip_tags() was the only function using them, to strip off ID3v1 and APE tags off the end of buffered tracks. This would save only 32-192 bytes per track -- if the container format uses APE/ID3v1. It hardly seems worth the effort. Change-Id: I8fc3c1408517eda6126e75e76d76daea904b50eb --- apps/playback.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'apps/playback.c') diff --git a/apps/playback.c b/apps/playback.c index a56c6d17ec..7fdb302d71 100644 --- a/apps/playback.c +++ b/apps/playback.c @@ -3467,9 +3467,6 @@ static void buffer_event_finished_callback(unsigned short id, void *ev_data) break; case TYPE_PACKET_AUDIO: - /* Strip any useless trailing tags that are left. */ - strip_tags(hid); - /* Fall-through */ case TYPE_ATOMIC_AUDIO: LOGFQUEUE("buffering > audio Q_AUDIO_HANDLE_FINISHED: %d", hid); audio_queue_post(Q_AUDIO_HANDLE_FINISHED, hid); -- cgit v1.2.3