summaryrefslogtreecommitdiff
path: root/apps/onplay.c
diff options
context:
space:
mode:
authorWilliam Wilgus <wilgus.william@gmail.com>2024-03-31 22:08:55 -0400
committerWilliam Wilgus <wilgus.william@gmail.com>2024-04-01 07:35:53 -0400
commit1dc22c7241e7a4560bc2ba5e920721df27c39778 (patch)
tree92005f1c98456b2db0cf78d30df9f0f648f75faf /apps/onplay.c
parent47784a777eca6cae3c4a6643f4bca5338373951f (diff)
downloadrockbox-1dc22c7241e7a4560bc2ba5e920721df27c39778.tar.gz
rockbox-1dc22c7241e7a4560bc2ba5e920721df27c39778.zip
use path_append for setting directories is several settings
sprintf, strcpy, memccpy can all just go thru path_append with the added benefit of some path sanitizing too Change-Id: I33510b56a364b8b3a0b06f2ff14b76491f6e3870
Diffstat (limited to 'apps/onplay.c')
-rw-r--r--apps/onplay.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/apps/onplay.c b/apps/onplay.c
index ba06d13183..ccebee402e 100644
--- a/apps/onplay.c
+++ b/apps/onplay.c
@@ -1349,8 +1349,8 @@ MENUITEM_FUNCTION(add_to_faves_item, 0, ID2P(LANG_ADD_TO_FAVES),
1349#if LCD_DEPTH > 1 1349#if LCD_DEPTH > 1
1350static bool set_backdrop(void) 1350static bool set_backdrop(void)
1351{ 1351{
1352 strmemccpy(global_settings.backdrop_file, selected_file, 1352 path_append(global_settings.backdrop_file, selected_file,
1353 sizeof(global_settings.backdrop_file)); 1353 PA_SEP_HARD, sizeof(global_settings.backdrop_file));
1354 settings_save(); 1354 settings_save();
1355 skin_backdrop_load_setting(); 1355 skin_backdrop_load_setting();
1356 skin_backdrop_show(sb_get_backdrop(SCREEN_MAIN)); 1356 skin_backdrop_show(sb_get_backdrop(SCREEN_MAIN));
@@ -1362,8 +1362,8 @@ MENUITEM_FUNCTION(set_backdrop_item, 0, ID2P(LANG_SET_AS_BACKDROP),
1362#ifdef HAVE_RECORDING 1362#ifdef HAVE_RECORDING
1363static bool set_recdir(void) 1363static bool set_recdir(void)
1364{ 1364{
1365 strmemccpy(global_settings.rec_directory, selected_file, 1365 path_append(global_settings.rec_directory, selected_file,
1366 sizeof(global_settings.rec_directory)); 1366 PA_SEP_HARD, sizeof(global_settings.rec_directory));
1367 settings_save(); 1367 settings_save();
1368 return false; 1368 return false;
1369} 1369}
@@ -1372,9 +1372,9 @@ MENUITEM_FUNCTION(set_recdir_item, 0, ID2P(LANG_RECORDING_DIR),
1372#endif 1372#endif
1373static bool set_startdir(void) 1373static bool set_startdir(void)
1374{ 1374{
1375 snprintf(global_settings.start_directory, 1375 path_append(global_settings.start_directory, selected_file,
1376 sizeof(global_settings.start_directory), 1376 PA_SEP_HARD, sizeof(global_settings.start_directory));
1377 "%s/", selected_file); 1377
1378 settings_save(); 1378 settings_save();
1379 return false; 1379 return false;
1380} 1380}