From 1dc22c7241e7a4560bc2ba5e920721df27c39778 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Sun, 31 Mar 2024 22:08:55 -0400 Subject: use path_append for setting directories is several settings sprintf, strcpy, memccpy can all just go thru path_append with the added benefit of some path sanitizing too Change-Id: I33510b56a364b8b3a0b06f2ff14b76491f6e3870 --- apps/onplay.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'apps/onplay.c') diff --git a/apps/onplay.c b/apps/onplay.c index ba06d13183..ccebee402e 100644 --- a/apps/onplay.c +++ b/apps/onplay.c @@ -1349,8 +1349,8 @@ MENUITEM_FUNCTION(add_to_faves_item, 0, ID2P(LANG_ADD_TO_FAVES), #if LCD_DEPTH > 1 static bool set_backdrop(void) { - strmemccpy(global_settings.backdrop_file, selected_file, - sizeof(global_settings.backdrop_file)); + path_append(global_settings.backdrop_file, selected_file, + PA_SEP_HARD, sizeof(global_settings.backdrop_file)); settings_save(); skin_backdrop_load_setting(); skin_backdrop_show(sb_get_backdrop(SCREEN_MAIN)); @@ -1362,8 +1362,8 @@ MENUITEM_FUNCTION(set_backdrop_item, 0, ID2P(LANG_SET_AS_BACKDROP), #ifdef HAVE_RECORDING static bool set_recdir(void) { - strmemccpy(global_settings.rec_directory, selected_file, - sizeof(global_settings.rec_directory)); + path_append(global_settings.rec_directory, selected_file, + PA_SEP_HARD, sizeof(global_settings.rec_directory)); settings_save(); return false; } @@ -1372,9 +1372,9 @@ MENUITEM_FUNCTION(set_recdir_item, 0, ID2P(LANG_RECORDING_DIR), #endif static bool set_startdir(void) { - snprintf(global_settings.start_directory, - sizeof(global_settings.start_directory), - "%s/", selected_file); + path_append(global_settings.start_directory, selected_file, + PA_SEP_HARD, sizeof(global_settings.start_directory)); + settings_save(); return false; } -- cgit v1.2.3