summaryrefslogtreecommitdiff
path: root/firmware
diff options
context:
space:
mode:
Diffstat (limited to 'firmware')
-rw-r--r--firmware/export/logf.h5
-rw-r--r--firmware/logf.c24
2 files changed, 15 insertions, 14 deletions
diff --git a/firmware/export/logf.h b/firmware/export/logf.h
index f74f50377e..7e9b27ab0a 100644
--- a/firmware/export/logf.h
+++ b/firmware/export/logf.h
@@ -23,9 +23,10 @@
23#ifdef ROCKBOX_HAS_LOGF 23#ifdef ROCKBOX_HAS_LOGF
24 24
25#define MAX_LOGF_LINES 1000 25#define MAX_LOGF_LINES 1000
26#define MAX_LOGF_DATASIZE (16*MAX_LOGF_LINES) 26#define MAX_LOGF_ENTRY 21 /* 128/6 pixels */
27#define MAX_LOGF_DATASIZE (MAX_LOGF_ENTRY*MAX_LOGF_LINES)
27 28
28extern unsigned char logfbuffer[MAX_LOGF_LINES][16]; 29extern unsigned char logfbuffer[MAX_LOGF_LINES][MAX_LOGF_ENTRY];
29extern int logfindex; 30extern int logfindex;
30extern bool logfwrap; 31extern bool logfwrap;
31 32
diff --git a/firmware/logf.c b/firmware/logf.c
index ab3d621428..a11987dd34 100644
--- a/firmware/logf.c
+++ b/firmware/logf.c
@@ -18,10 +18,10 @@
18 ****************************************************************************/ 18 ****************************************************************************/
19 19
20/* 20/*
21 * logf() logs 16 bytes in a circular buffer. Each logged string is space- 21 * logf() logs MAX_LOGF_ENTRY (21) bytes per entry in a circular buffer. Each
22 * padded for easier and faster output on screen. Just output 16 lines on each 22 * logged string is space- padded for easier and faster output on screen. Just
23 * line. 16 bytes fit nicely on the iRiver remote LCD (128 pixels with an 8 23 * output MAX_LOGF_ENTRY characters on each line. MAX_LOGF_ENTRY bytes fit
24 * pixels font). 24 * nicely on the iRiver remote LCD (128 pixels with an 8x6 pixels font).
25 */ 25 */
26 26
27#include <string.h> 27#include <string.h>
@@ -36,7 +36,7 @@
36/* Only provide all this if asked to */ 36/* Only provide all this if asked to */
37#ifdef ROCKBOX_HAS_LOGF 37#ifdef ROCKBOX_HAS_LOGF
38 38
39unsigned char logfbuffer[MAX_LOGF_LINES][16]; 39unsigned char logfbuffer[MAX_LOGF_LINES][MAX_LOGF_ENTRY];
40int logfindex; 40int logfindex;
41bool logfwrap; 41bool logfwrap;
42 42
@@ -57,7 +57,7 @@ static void displayremote(void)
57 57
58 index = logfindex; 58 index = logfindex;
59 for(i = lines-1; i>=0; i--) { 59 for(i = lines-1; i>=0; i--) {
60 unsigned char buffer[17]; 60 unsigned char buffer[MAX_LOGF_ENTRY+1];
61 61
62 if(--index < 0) { 62 if(--index < 0) {
63 if(logfwrap) 63 if(logfwrap)
@@ -66,8 +66,8 @@ static void displayremote(void)
66 break; /* done */ 66 break; /* done */
67 } 67 }
68 68
69 memcpy(buffer, logfbuffer[index], 16); 69 memcpy(buffer, logfbuffer[index], MAX_LOGF_ENTRY);
70 buffer[16]=0; 70 buffer[MAX_LOGF_ENTRY]=0;
71 lcd_remote_puts(0, i, buffer); 71 lcd_remote_puts(0, i, buffer);
72 } 72 }
73 lcd_remote_update(); 73 lcd_remote_update();
@@ -89,11 +89,11 @@ void logf(const char *format, ...)
89 logfindex = 0; 89 logfindex = 0;
90 } 90 }
91 ptr = logfbuffer[logfindex]; 91 ptr = logfbuffer[logfindex];
92 len = vsnprintf(ptr, 16, format, ap); 92 len = vsnprintf(ptr, MAX_LOGF_ENTRY, format, ap);
93 va_end(ap); 93 va_end(ap);
94 if(len < 16) 94 if(len < MAX_LOGF_ENTRY)
95 /* pad with spaces up to the 16 byte border */ 95 /* pad with spaces up to the MAX_LOGF_ENTRY byte border */
96 memset(ptr+len, ' ', 16-len); 96 memset(ptr+len, ' ', MAX_LOGF_ENTRY-len);
97 97
98 logfindex++; /* leave it where we write the next time */ 98 logfindex++; /* leave it where we write the next time */
99 99