diff options
Diffstat (limited to 'firmware/common')
-rw-r--r-- | firmware/common/dircache.c | 8 | ||||
-rw-r--r-- | firmware/common/zip.c | 20 |
2 files changed, 10 insertions, 18 deletions
diff --git a/firmware/common/dircache.c b/firmware/common/dircache.c index 7a84b761a0..8917b3348e 100644 --- a/firmware/common/dircache.c +++ b/firmware/common/dircache.c | |||
@@ -1963,8 +1963,7 @@ static int prepare_build(bool *realloced) | |||
1963 | int handle = reset_buffer(); | 1963 | int handle = reset_buffer(); |
1964 | dircache_unlock(); | 1964 | dircache_unlock(); |
1965 | 1965 | ||
1966 | if (handle > 0) | 1966 | core_free(handle); |
1967 | core_free(handle); | ||
1968 | 1967 | ||
1969 | handle = alloc_cache(size); | 1968 | handle = alloc_cache(size); |
1970 | 1969 | ||
@@ -2164,8 +2163,7 @@ static void dircache_suspend_internal(bool freeit) | |||
2164 | 2163 | ||
2165 | dircache_unlock(); | 2164 | dircache_unlock(); |
2166 | 2165 | ||
2167 | if (handle > 0) | 2166 | core_free(handle); |
2168 | core_free(handle); | ||
2169 | 2167 | ||
2170 | thread_wait(thread_id); | 2168 | thread_wait(thread_id); |
2171 | 2169 | ||
@@ -3179,7 +3177,7 @@ error: | |||
3179 | dircache_unlock(); | 3177 | dircache_unlock(); |
3180 | 3178 | ||
3181 | error_nolock: | 3179 | error_nolock: |
3182 | if (rc < 0 && handle > 0) | 3180 | if (rc < 0) |
3183 | core_free(handle); | 3181 | core_free(handle); |
3184 | 3182 | ||
3185 | if (fd >= 0) | 3183 | if (fd >= 0) |
diff --git a/firmware/common/zip.c b/firmware/common/zip.c index 36b90a9223..22c6226e3b 100644 --- a/firmware/common/zip.c +++ b/firmware/common/zip.c | |||
@@ -237,8 +237,7 @@ static int zip_read_ed(struct zip* z) { | |||
237 | rv = 0; | 237 | rv = 0; |
238 | 238 | ||
239 | bail: | 239 | bail: |
240 | if (mem_handle >= 0) | 240 | core_free(mem_handle); |
241 | core_free(mem_handle); | ||
242 | return rv; | 241 | return rv; |
243 | } | 242 | } |
244 | 243 | ||
@@ -337,10 +336,9 @@ static int zip_read_cd(struct zip* z, bool use_cb) { | |||
337 | rv = 0; | 336 | rv = 0; |
338 | 337 | ||
339 | bail: | 338 | bail: |
340 | if (rv != 0 && cds_handle >= 0) | 339 | if (rv != 0) |
341 | core_free(cds_handle); | 340 | core_free(cds_handle); |
342 | if (mem_handle >= 0) | 341 | core_free(mem_handle); |
343 | core_free(mem_handle); | ||
344 | return rv; | 342 | return rv; |
345 | } | 343 | } |
346 | 344 | ||
@@ -497,8 +495,7 @@ static int zip_read_entries(struct zip* z) { | |||
497 | rv = 0; | 495 | rv = 0; |
498 | 496 | ||
499 | bail: | 497 | bail: |
500 | if (mem_handle >= 0) | 498 | core_free(mem_handle); |
501 | core_free(mem_handle); | ||
502 | return rv; | 499 | return rv; |
503 | } | 500 | } |
504 | 501 | ||
@@ -754,10 +751,8 @@ struct zip* zip_open(const char* name, bool try_mem) { | |||
754 | bail: | 751 | bail: |
755 | if (file >= 0) | 752 | if (file >= 0) |
756 | close(file); | 753 | close(file); |
757 | if (mem_handle >= 0) | 754 | core_free(mem_handle); |
758 | core_free(mem_handle); | 755 | core_free(zip_handle); |
759 | if (zip_handle >= 0) | ||
760 | core_free(zip_handle); | ||
761 | return NULL; | 756 | return NULL; |
762 | } | 757 | } |
763 | 758 | ||
@@ -875,8 +870,7 @@ void zip_close(struct zip* z) { | |||
875 | 870 | ||
876 | z->close(z); | 871 | z->close(z); |
877 | 872 | ||
878 | if (z->cds_handle >= 0) | 873 | core_free(z->cds_handle); |
879 | core_free(z->cds_handle); | ||
880 | 874 | ||
881 | core_free(z->zip_handle); | 875 | core_free(z->zip_handle); |
882 | } | 876 | } |