diff options
Diffstat (limited to 'apps')
-rw-r--r-- | apps/pcmbuf.c | 9 | ||||
-rw-r--r-- | apps/playback.c | 9 |
2 files changed, 10 insertions, 8 deletions
diff --git a/apps/pcmbuf.c b/apps/pcmbuf.c index 6d2f68a238..964ebbc901 100644 --- a/apps/pcmbuf.c +++ b/apps/pcmbuf.c | |||
@@ -38,7 +38,7 @@ | |||
38 | #include "thread.h" | 38 | #include "thread.h" |
39 | 39 | ||
40 | /* Keep watermark high for iPods at least (2s) */ | 40 | /* Keep watermark high for iPods at least (2s) */ |
41 | #define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 8) | 41 | #define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 4 * 2) |
42 | 42 | ||
43 | /* Structure we can use to queue pcm chunks in memory to be played | 43 | /* Structure we can use to queue pcm chunks in memory to be played |
44 | * by the driver code. */ | 44 | * by the driver code. */ |
@@ -203,6 +203,13 @@ process_new_buffer: | |||
203 | *realsize = 0; | 203 | *realsize = 0; |
204 | *realstart = NULL; | 204 | *realstart = NULL; |
205 | CALL_IF_EXISTS(pcmbuf_event_handler); | 205 | CALL_IF_EXISTS(pcmbuf_event_handler); |
206 | /* FIXME: We need to find another way to keep the CPU from | ||
207 | * being left boosted, because this is boosting in interrupt | ||
208 | * context. This is also not a good thing, because it will | ||
209 | * result in the CPU being deboosted if there is a legitimate | ||
210 | * buffer underrun (albeit only temporarily, because someone | ||
211 | * will reboost it soon, but it will make the skip longer | ||
212 | * than necessary. */ | ||
206 | pcmbuf_boost(false); | 213 | pcmbuf_boost(false); |
207 | } | 214 | } |
208 | } | 215 | } |
diff --git a/apps/playback.c b/apps/playback.c index 8ac669c172..8c480c46c7 100644 --- a/apps/playback.c +++ b/apps/playback.c | |||
@@ -17,19 +17,14 @@ | |||
17 | * | 17 | * |
18 | ****************************************************************************/ | 18 | ****************************************************************************/ |
19 | 19 | ||
20 | /* TODO: Check for a possibly broken codepath on a rapid skip, stop event */ | ||
21 | /* TODO: same in reverse ^^ */ | ||
22 | /* TODO: Also play, stop ^^ */ | ||
23 | /* TODO: Can use the track changed callback to detect end of track and seek | 20 | /* TODO: Can use the track changed callback to detect end of track and seek |
24 | * in the previous track until this happens */ | 21 | * in the previous track until this happens */ |
25 | /* TODO: Pause should be handled in here, rather than PCMBUF so that voice can | ||
26 | * play whilst audio is paused */ | ||
27 | /* Design: we have prev_ti already, have a conditional for what type of seek | 22 | /* Design: we have prev_ti already, have a conditional for what type of seek |
28 | * to do on a seek request, if it is a previous track seek, skip previous, | 23 | * to do on a seek request, if it is a previous track seek, skip previous, |
29 | * and in the request_next_track callback set the offset up the same way that | 24 | * and in the request_next_track callback set the offset up the same way that |
30 | * starting from an offset works. */ | 25 | * starting from an offset works. */ |
31 | /* This is also necesary to prevent the problem with buffer overwriting on | 26 | /* TODO: Pause should be handled in here, rather than PCMBUF so that voice can |
32 | * automatic track changes */ | 27 | * play whilst audio is paused */ |
33 | 28 | ||
34 | #include <stdio.h> | 29 | #include <stdio.h> |
35 | #include <string.h> | 30 | #include <string.h> |