diff options
| author | Amaury Pouly <amaury.pouly@gmail.com> | 2016-08-15 16:32:05 +0100 |
|---|---|---|
| committer | Gerrit Rockbox <gerrit@rockbox.org> | 2016-08-29 08:16:27 +0200 |
| commit | afe7f1b91568e742f3302f8e7b86fc7cd35b390b (patch) | |
| tree | 24ad95956838fc2ba77d002bc5664effe99b64ea /tools | |
| parent | cbcc8f368f13a699bea563a136304acaa1dc8a8e (diff) | |
| download | rockbox-afe7f1b91568e742f3302f8e7b86fc7cd35b390b.tar.gz rockbox-afe7f1b91568e742f3302f8e7b86fc7cd35b390b.zip | |
as3543: fix audio gap when switching from dac to line-in/recording
Also clarity parts of the code. The old code suffered from two defects:
- it was very unclear because it made changes to whole registers
(using as3514_write) instead of fields (using as3514_set/clear/write_masked).
Also the routing code was spread accross several functions which made it hard to
follow.
- it did not properly reroute audio on monitor changes. In particular, the following
could happen: when switching from DAC to radio, the code would fail to clear
SUM_off, resulting in a weird situation where the main mixer was off
(SUM_off) but the headphone where using the main mixer as input. Incredibly this
worked anyway (at least on AMSv2 and YP-R0) but resulted in strange volume gaps
between DAC and radio mode.
Change-Id: I7826835fdb59c21f6483b223883ca9289e85caca
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions