summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorLorenzo Miori <memoryS60@gmail.com>2014-01-04 22:23:34 +0100
committerGerrit Rockbox <gerrit@rockbox.org>2015-01-29 20:28:07 +0100
commit6879dec6ece3c0797c5df16c9dd494b3dc3a1329 (patch)
tree1d8cfd1905468d3b6a6d98b6aea3c00f4c26354c /tools
parentf65baf9b0f385bc479de9ab2eb92aab23167eba8 (diff)
downloadrockbox-6879dec6ece3c0797c5df16c9dd494b3dc3a1329.tar.gz
rockbox-6879dec6ece3c0797c5df16c9dd494b3dc3a1329.zip
yp-r0: improve the charging code
Some people reported strange charging times and strange battery life. Charging by OF: 25 hours; RB: 18 hours It has been found that there are at least two issues here: 1) the way of getting battery charging status wasn't really accurate. This attempts to fix that issue. This patch also simplifies some code (opening a device is no more needed, for example). To technically explain, battery charging implies first a constant current mode (where the voltage increases) and then a constant voltage mode (where, obviously, the voltage reads more or less the same). The old way the End Of Charge was detected was based solely on the voltage, while now it is based on chip's EOC interrupt, which should be more accurate. 2) OF explicitly sets a constant current 350 mA, while we usually had 55 mA (by as3543 default). This wasn't discovered before since there is a caching problem ("an accurate guess") in the Samsung power mgmt Linux module, thus its debugging dumper wasn't really working, reporting a 55 mA current. Strangely this option should have been set by the bootloader but apparently it does not. Some testing is still needed, but I confirm that with this patch I could run a benchmark for 25 hours (vs. 18 hours), by charging within Rockbox of course. Change-Id: I3bd921e86b9018d1cc3c720d15cc46896e8490b3
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions