diff options
author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2013-11-03 11:08:18 +0100 |
---|---|---|
committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2013-11-04 23:32:52 +0100 |
commit | 4d2ce949b3b41f8bf0af446fa20205ddd229e579 (patch) | |
tree | 01fa19471d9831b296bea5d7049f765e38b30bbb /rbutil/rbutilqt/gui | |
parent | 335ec75d60bba82f23fc47b20f9390e0cba9c9c5 (diff) | |
download | rockbox-4d2ce949b3b41f8bf0af446fa20205ddd229e579.tar.gz rockbox-4d2ce949b3b41f8bf0af446fa20205ddd229e579.zip |
Use cutelogger for Rockbox Utility internal trace.
Change tracing from qDebug() to use cutelogger, which is available under the
LGPL2.1. This allows to automatically add filename and line number to the log,
and also provides multiple log levels.
Change-Id: I5dbdaf902ba54ea99f07ae10a07467c52fdac910
Diffstat (limited to 'rbutil/rbutilqt/gui')
-rw-r--r-- | rbutil/rbutilqt/gui/backupdialog.cpp | 5 | ||||
-rw-r--r-- | rbutil/rbutilqt/gui/infowidget.cpp | 3 | ||||
-rw-r--r-- | rbutil/rbutilqt/gui/manualwidget.cpp | 3 | ||||
-rw-r--r-- | rbutil/rbutilqt/gui/selectiveinstallwidget.cpp | 35 |
4 files changed, 25 insertions, 21 deletions
diff --git a/rbutil/rbutilqt/gui/backupdialog.cpp b/rbutil/rbutilqt/gui/backupdialog.cpp index 1571ae9191..f12c47b570 100644 --- a/rbutil/rbutilqt/gui/backupdialog.cpp +++ b/rbutil/rbutilqt/gui/backupdialog.cpp | |||
@@ -26,6 +26,7 @@ | |||
26 | #include "progressloggergui.h" | 26 | #include "progressloggergui.h" |
27 | #include "ziputil.h" | 27 | #include "ziputil.h" |
28 | #include "rockboxinfo.h" | 28 | #include "rockboxinfo.h" |
29 | #include "Logger.h" | ||
29 | 30 | ||
30 | class BackupSizeThread : public QThread | 31 | class BackupSizeThread : public QThread |
31 | { | 32 | { |
@@ -42,14 +43,14 @@ class BackupSizeThread : public QThread | |||
42 | 43 | ||
43 | void BackupSizeThread::run(void) | 44 | void BackupSizeThread::run(void) |
44 | { | 45 | { |
45 | qDebug() << "BackupSizeThread] Thread started, calculating" << m_path; | 46 | LOG_INFO() << "Thread started, calculating" << m_path; |
46 | m_currentSize = 0; | 47 | m_currentSize = 0; |
47 | 48 | ||
48 | QDirIterator it(m_path, QDirIterator::Subdirectories); | 49 | QDirIterator it(m_path, QDirIterator::Subdirectories); |
49 | while(it.hasNext()) { | 50 | while(it.hasNext()) { |
50 | m_currentSize += QFileInfo(it.next()).size(); | 51 | m_currentSize += QFileInfo(it.next()).size(); |
51 | } | 52 | } |
52 | qDebug() << "[BackupSizeThread] Thread done, sum:" << m_currentSize; | 53 | LOG_INFO() << "Thread done, sum:" << m_currentSize; |
53 | } | 54 | } |
54 | 55 | ||
55 | 56 | ||
diff --git a/rbutil/rbutilqt/gui/infowidget.cpp b/rbutil/rbutilqt/gui/infowidget.cpp index bfc0742593..25b0503090 100644 --- a/rbutil/rbutilqt/gui/infowidget.cpp +++ b/rbutil/rbutilqt/gui/infowidget.cpp | |||
@@ -20,6 +20,7 @@ | |||
20 | #include <QDebug> | 20 | #include <QDebug> |
21 | #include "infowidget.h" | 21 | #include "infowidget.h" |
22 | #include "rbsettings.h" | 22 | #include "rbsettings.h" |
23 | #include "Logger.h" | ||
23 | 24 | ||
24 | InfoWidget::InfoWidget(QWidget *parent) : QWidget(parent) | 25 | InfoWidget::InfoWidget(QWidget *parent) : QWidget(parent) |
25 | { | 26 | { |
@@ -35,7 +36,7 @@ InfoWidget::InfoWidget(QWidget *parent) : QWidget(parent) | |||
35 | 36 | ||
36 | void InfoWidget::updateInfo(void) | 37 | void InfoWidget::updateInfo(void) |
37 | { | 38 | { |
38 | qDebug() << "[InfoWidget] updating server info"; | 39 | LOG_INFO() << "updating server info"; |
39 | 40 | ||
40 | QString mp = RbSettings::value(RbSettings::Mountpoint).toString(); | 41 | QString mp = RbSettings::value(RbSettings::Mountpoint).toString(); |
41 | QSettings log(mp + "/.rockbox/rbutil.log", QSettings::IniFormat, this); | 42 | QSettings log(mp + "/.rockbox/rbutil.log", QSettings::IniFormat, this); |
diff --git a/rbutil/rbutilqt/gui/manualwidget.cpp b/rbutil/rbutilqt/gui/manualwidget.cpp index dc68e65460..0ba3012aea 100644 --- a/rbutil/rbutilqt/gui/manualwidget.cpp +++ b/rbutil/rbutilqt/gui/manualwidget.cpp | |||
@@ -24,6 +24,7 @@ | |||
24 | #include "rbsettings.h" | 24 | #include "rbsettings.h" |
25 | #include "serverinfo.h" | 25 | #include "serverinfo.h" |
26 | #include "systeminfo.h" | 26 | #include "systeminfo.h" |
27 | #include "Logger.h" | ||
27 | 28 | ||
28 | ManualWidget::ManualWidget(QWidget *parent) : QWidget(parent) | 29 | ManualWidget::ManualWidget(QWidget *parent) : QWidget(parent) |
29 | { | 30 | { |
@@ -36,7 +37,7 @@ ManualWidget::ManualWidget(QWidget *parent) : QWidget(parent) | |||
36 | 37 | ||
37 | void ManualWidget::updateManual() | 38 | void ManualWidget::updateManual() |
38 | { | 39 | { |
39 | qDebug() << "[ManualWidget] updating manual URLs"; | 40 | LOG_INFO() << "updating manual URLs"; |
40 | m_platform = RbSettings::value(RbSettings::Platform).toString(); | 41 | m_platform = RbSettings::value(RbSettings::Platform).toString(); |
41 | if(!m_platform.isEmpty()) | 42 | if(!m_platform.isEmpty()) |
42 | { | 43 | { |
diff --git a/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp b/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp index 96183d1075..35837ba41d 100644 --- a/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp +++ b/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp | |||
@@ -30,6 +30,7 @@ | |||
30 | #include "bootloaderinstallhelper.h" | 30 | #include "bootloaderinstallhelper.h" |
31 | #include "themesinstallwindow.h" | 31 | #include "themesinstallwindow.h" |
32 | #include "utils.h" | 32 | #include "utils.h" |
33 | #include "Logger.h" | ||
33 | 34 | ||
34 | SelectiveInstallWidget::SelectiveInstallWidget(QWidget* parent) : QWidget(parent) | 35 | SelectiveInstallWidget::SelectiveInstallWidget(QWidget* parent) : QWidget(parent) |
35 | { | 36 | { |
@@ -147,7 +148,7 @@ void SelectiveInstallWidget::updateVersion(void) | |||
147 | 148 | ||
148 | void SelectiveInstallWidget::saveSettings(void) | 149 | void SelectiveInstallWidget::saveSettings(void) |
149 | { | 150 | { |
150 | qDebug() << "[SelectiveInstallWidget] saving current settings"; | 151 | LOG_INFO() << "saving current settings"; |
151 | 152 | ||
152 | RbSettings::setValue(RbSettings::InstallRockbox, ui.rockboxCheckbox->isChecked()); | 153 | RbSettings::setValue(RbSettings::InstallRockbox, ui.rockboxCheckbox->isChecked()); |
153 | RbSettings::setValue(RbSettings::InstallFonts, ui.fontsCheckbox->isChecked()); | 154 | RbSettings::setValue(RbSettings::InstallFonts, ui.fontsCheckbox->isChecked()); |
@@ -158,7 +159,7 @@ void SelectiveInstallWidget::saveSettings(void) | |||
158 | 159 | ||
159 | void SelectiveInstallWidget::startInstall(void) | 160 | void SelectiveInstallWidget::startInstall(void) |
160 | { | 161 | { |
161 | qDebug() << "[SelectiveInstallWidget] starting installation"; | 162 | LOG_INFO() << "starting installation"; |
162 | saveSettings(); | 163 | saveSettings(); |
163 | 164 | ||
164 | m_installStage = 0; | 165 | m_installStage = 0; |
@@ -191,15 +192,15 @@ void SelectiveInstallWidget::startInstall(void) | |||
191 | 192 | ||
192 | void SelectiveInstallWidget::continueInstall(bool error) | 193 | void SelectiveInstallWidget::continueInstall(bool error) |
193 | { | 194 | { |
194 | qDebug() << "[SelectiveInstallWidget] continuing install with stage" << m_installStage; | 195 | LOG_INFO() << "continuing install with stage" << m_installStage; |
195 | if(error) { | 196 | if(error) { |
196 | qDebug() << "[SelectiveInstallWidget] Last part returned error."; | 197 | LOG_ERROR() << "Last part returned error."; |
197 | m_logger->setFinished(); | 198 | m_logger->setFinished(); |
198 | m_installStage = 7; | 199 | m_installStage = 7; |
199 | } | 200 | } |
200 | m_installStage++; | 201 | m_installStage++; |
201 | switch(m_installStage) { | 202 | switch(m_installStage) { |
202 | case 0: qDebug() << "[SelectiveInstallWidget] Something wrong!"; break; | 203 | case 0: LOG_ERROR() << "Something wrong!"; break; |
203 | case 1: installBootloader(); break; | 204 | case 1: installBootloader(); break; |
204 | case 2: installRockbox(); break; | 205 | case 2: installRockbox(); break; |
205 | case 3: installFonts(); break; | 206 | case 3: installFonts(); break; |
@@ -210,7 +211,7 @@ void SelectiveInstallWidget::continueInstall(bool error) | |||
210 | } | 211 | } |
211 | 212 | ||
212 | if(m_installStage > 6) { | 213 | if(m_installStage > 6) { |
213 | qDebug() << "[SelectiveInstallWidget] All install stages done."; | 214 | LOG_INFO() << "All install stages done."; |
214 | m_logger->setFinished(); | 215 | m_logger->setFinished(); |
215 | if(m_blmethod != "none") { | 216 | if(m_blmethod != "none") { |
216 | // check if Rockbox is installed by looking after rockbox-info.txt. | 217 | // check if Rockbox is installed by looking after rockbox-info.txt. |
@@ -225,7 +226,7 @@ void SelectiveInstallWidget::continueInstall(bool error) | |||
225 | void SelectiveInstallWidget::installBootloader(void) | 226 | void SelectiveInstallWidget::installBootloader(void) |
226 | { | 227 | { |
227 | if(ui.bootloaderCheckbox->isChecked()) { | 228 | if(ui.bootloaderCheckbox->isChecked()) { |
228 | qDebug() << "[SelectiveInstallWidget] installing bootloader"; | 229 | LOG_INFO() << "installing bootloader"; |
229 | 230 | ||
230 | QString platform = RbSettings::value(RbSettings::Platform).toString(); | 231 | QString platform = RbSettings::value(RbSettings::Platform).toString(); |
231 | QString backupDestination = ""; | 232 | QString backupDestination = ""; |
@@ -292,7 +293,7 @@ void SelectiveInstallWidget::installBootloader(void) | |||
292 | if(!backupDestination.isEmpty()) | 293 | if(!backupDestination.isEmpty()) |
293 | backupDestination += "/" + targetFolder; | 294 | backupDestination += "/" + targetFolder; |
294 | 295 | ||
295 | qDebug() << "[RbUtil] backing up to" << backupDestination; | 296 | LOG_INFO() << "backing up to" << backupDestination; |
296 | // backup needs to be done after the m_logger has been set up. | 297 | // backup needs to be done after the m_logger has been set up. |
297 | } | 298 | } |
298 | } | 299 | } |
@@ -350,7 +351,7 @@ void SelectiveInstallWidget::installBootloader(void) | |||
350 | 351 | ||
351 | } | 352 | } |
352 | else { | 353 | else { |
353 | qDebug() << "[SelectiveInstallWidget] Bootloader install disabled."; | 354 | LOG_INFO() << "Bootloader install disabled."; |
354 | emit installSkipped(false); | 355 | emit installSkipped(false); |
355 | } | 356 | } |
356 | } | 357 | } |
@@ -372,7 +373,7 @@ void SelectiveInstallWidget::installBootloaderPost() | |||
372 | void SelectiveInstallWidget::installRockbox(void) | 373 | void SelectiveInstallWidget::installRockbox(void) |
373 | { | 374 | { |
374 | if(ui.rockboxCheckbox->isChecked()) { | 375 | if(ui.rockboxCheckbox->isChecked()) { |
375 | qDebug() << "[SelectiveInstallWidget] installing Rockbox"; | 376 | LOG_INFO() << "installing Rockbox"; |
376 | QString url; | 377 | QString url; |
377 | 378 | ||
378 | QString selected = ui.selectedVersion->itemData(ui.selectedVersion->currentIndex()).toString(); | 379 | QString selected = ui.selectedVersion->itemData(ui.selectedVersion->currentIndex()).toString(); |
@@ -405,7 +406,7 @@ void SelectiveInstallWidget::installRockbox(void) | |||
405 | 406 | ||
406 | } | 407 | } |
407 | else { | 408 | else { |
408 | qDebug() << "[SelectiveInstallWidget] Rockbox install disabled."; | 409 | LOG_INFO() << "Rockbox install disabled."; |
409 | emit installSkipped(false); | 410 | emit installSkipped(false); |
410 | } | 411 | } |
411 | } | 412 | } |
@@ -414,7 +415,7 @@ void SelectiveInstallWidget::installRockbox(void) | |||
414 | void SelectiveInstallWidget::installFonts(void) | 415 | void SelectiveInstallWidget::installFonts(void) |
415 | { | 416 | { |
416 | if(ui.fontsCheckbox->isChecked()) { | 417 | if(ui.fontsCheckbox->isChecked()) { |
417 | qDebug() << "[SelectiveInstallWidget] installing Fonts"; | 418 | LOG_INFO() << "installing Fonts"; |
418 | 419 | ||
419 | RockboxInfo installInfo(m_mountpoint); | 420 | RockboxInfo installInfo(m_mountpoint); |
420 | QString fontsurl; | 421 | QString fontsurl; |
@@ -447,7 +448,7 @@ void SelectiveInstallWidget::installFonts(void) | |||
447 | m_zipinstaller->install(); | 448 | m_zipinstaller->install(); |
448 | } | 449 | } |
449 | else { | 450 | else { |
450 | qDebug() << "[SelectiveInstallWidget] Fonts install disabled."; | 451 | LOG_INFO() << "Fonts install disabled."; |
451 | emit installSkipped(false); | 452 | emit installSkipped(false); |
452 | } | 453 | } |
453 | } | 454 | } |
@@ -465,7 +466,7 @@ void SelectiveInstallWidget::customizeThemes(void) | |||
465 | void SelectiveInstallWidget::installThemes(void) | 466 | void SelectiveInstallWidget::installThemes(void) |
466 | { | 467 | { |
467 | if(ui.themesCheckbox->isChecked()) { | 468 | if(ui.themesCheckbox->isChecked()) { |
468 | qDebug() << "[SelectiveInstallWidget] installing themes"; | 469 | LOG_INFO() << "installing themes"; |
469 | if(m_themesinstaller == NULL) | 470 | if(m_themesinstaller == NULL) |
470 | m_themesinstaller = new ThemesInstallWindow(this); | 471 | m_themesinstaller = new ThemesInstallWindow(this); |
471 | 472 | ||
@@ -475,7 +476,7 @@ void SelectiveInstallWidget::installThemes(void) | |||
475 | m_themesinstaller->install(); | 476 | m_themesinstaller->install(); |
476 | } | 477 | } |
477 | else { | 478 | else { |
478 | qDebug() << "[SelectiveInstallWidget] Themes install disabled."; | 479 | LOG_INFO() << "Themes install disabled."; |
479 | emit installSkipped(false); | 480 | emit installSkipped(false); |
480 | } | 481 | } |
481 | } | 482 | } |
@@ -489,7 +490,7 @@ void SelectiveInstallWidget::installGamefiles(void) | |||
489 | m_logger->addItem(tr("Your installation doesn't require game files, skipping."), LOGINFO); | 490 | m_logger->addItem(tr("Your installation doesn't require game files, skipping."), LOGINFO); |
490 | emit installSkipped(false); | 491 | emit installSkipped(false); |
491 | } | 492 | } |
492 | qDebug() << "[SelectiveInstallWidget] installing gamefiles"; | 493 | LOG_INFO() << "installing gamefiles"; |
493 | // create new zip installer | 494 | // create new zip installer |
494 | if(m_zipinstaller != NULL) m_zipinstaller->deleteLater(); | 495 | if(m_zipinstaller != NULL) m_zipinstaller->deleteLater(); |
495 | m_zipinstaller = new ZipInstaller(this); | 496 | m_zipinstaller = new ZipInstaller(this); |
@@ -507,7 +508,7 @@ void SelectiveInstallWidget::installGamefiles(void) | |||
507 | m_zipinstaller->install(); | 508 | m_zipinstaller->install(); |
508 | } | 509 | } |
509 | else { | 510 | else { |
510 | qDebug() << "[SelectiveInstallWidget] Gamefile install disabled."; | 511 | LOG_INFO() << "Gamefile install disabled."; |
511 | emit installSkipped(false); | 512 | emit installSkipped(false); |
512 | } | 513 | } |
513 | } | 514 | } |