diff options
author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2020-11-15 21:55:34 +0100 |
---|---|---|
committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2020-11-15 21:55:34 +0100 |
commit | dec5421ca2cb5ac9e77ce96507d0285a6b0fcfee (patch) | |
tree | d8a93441f1ed6f4c21f5e483fa42d5fe7f97b1eb /rbutil/rbutilqt/gui/selectiveinstallwidget.cpp | |
parent | af766ae10eb10685bfd81124738b167294b7a8f2 (diff) | |
download | rockbox-dec5421ca2cb5ac9e77ce96507d0285a6b0fcfee.tar.gz rockbox-dec5421ca2cb5ac9e77ce96507d0285a6b0fcfee.zip |
rbutil: Rework server info data handling.
Return status as int, not as string, and provide a separate function for
converting to string. This allows to filter based on the actual status,
not a (localized) status string, which is more robust.
Fix a regression that made players with missing status value show up as
retired.
Change-Id: I15f83ae0df484199b1b3b5b95069db8b4d425987
Diffstat (limited to 'rbutil/rbutilqt/gui/selectiveinstallwidget.cpp')
-rw-r--r-- | rbutil/rbutilqt/gui/selectiveinstallwidget.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp b/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp index 065a139436..f875844c9c 100644 --- a/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp +++ b/rbutil/rbutilqt/gui/selectiveinstallwidget.cpp | |||
@@ -93,7 +93,7 @@ void SelectiveInstallWidget::updateVersion(void) | |||
93 | m_versions.clear(); | 93 | m_versions.clear(); |
94 | m_versions.insert("release", ServerInfo::platformValue(ServerInfo::CurReleaseVersion).toString()); | 94 | m_versions.insert("release", ServerInfo::platformValue(ServerInfo::CurReleaseVersion).toString()); |
95 | // Don't populate RC or development selections if target has been retired. | 95 | // Don't populate RC or development selections if target has been retired. |
96 | if (ServerInfo::platformValue(ServerInfo::CurStatus) != tr("Stable (Retired)")) { | 96 | if (ServerInfo::platformValue(ServerInfo::CurStatus).toInt() != STATUS_RETIRED) { |
97 | m_versions.insert("development", ServerInfo::platformValue(ServerInfo::BleedingRevision).toString()); | 97 | m_versions.insert("development", ServerInfo::platformValue(ServerInfo::BleedingRevision).toString()); |
98 | m_versions.insert("rc", ServerInfo::platformValue(ServerInfo::RelCandidateVersion).toString()); | 98 | m_versions.insert("rc", ServerInfo::platformValue(ServerInfo::RelCandidateVersion).toString()); |
99 | } | 99 | } |