Don't ignore errors when finishing a HTTP request for cached request as that is already done. Fixes a wrong status reported when an error occured.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20435 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 1 insertions, 5 deletions

diff --git a/rbutil/rbutilqt/base/httpget.cpp b/rbutil/rbutilqt/base/httpget.cpp
index bd15de41a9..5aabc5b29c 100644
--- a/rbutil/rbutilqt/base/httpget.cpp
+++ b/rbutil/rbutilqt/base/httpget.cpp
@@ -255,7 +255,7 @@ void HttpGet::getFileFinish()
             }
             m_response = 200; // fake "200 OK" HTTP response
             m_cached = true;
-            httpDone(false); // we're done now. Fake http "done" signal.
+            httpDone(false); // we're done now. Handle http "done" signal.
             return;
         }
         else {
@@ -313,10 +313,6 @@ void HttpGet::httpDone(bool error)
 
         c.close();
     }
-    // if cached file found and cache enabled ignore http errors
-    if(m_usecache && m_cached && !http.hasPendingRequests()) {
-        error = false;
-    }
     // take care of concurring requests. If there is still one running,
     // don't emit done(). That request will call this slot again.
     if(http.currentId() == 0 && !http.hasPendingRequests())