diff options
author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2020-11-28 20:47:28 +0100 |
---|---|---|
committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2020-12-03 22:25:12 +0100 |
commit | b064a6cbb58a0db1a70fbac2e82242ce0c7509b1 (patch) | |
tree | c9090d367d237cbd408afbd24d5809e55a1a2653 /rbutil/rbutilqt/base/bootloaderinstalls5l.cpp | |
parent | 78a01db47cac5fa67aeee6f1c5134f89c3e4944a (diff) | |
download | rockbox-b064a6cbb58a0db1a70fbac2e82242ce0c7509b1.tar.gz rockbox-b064a6cbb58a0db1a70fbac2e82242ce0c7509b1.zip |
rbutil: Rework and merge player and build server info handling.
Handling the data for players from rbutil.ini and the build-info data
from the server is closely related. Splitting things up into different
classes only creates tightly coupling, which is unnecessary, and the
need to differentiate between them in the application.
Merge both classes into a single one and rework handling so the
application doesn't have to deal with two separate classes anymore.
Furthermore, change URL templates to use new values from build-info
instead of hard coding them.
Change-Id: Ica550973ce23d1559110782add52bc214eba552d
Diffstat (limited to 'rbutil/rbutilqt/base/bootloaderinstalls5l.cpp')
-rw-r--r-- | rbutil/rbutilqt/base/bootloaderinstalls5l.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/rbutil/rbutilqt/base/bootloaderinstalls5l.cpp b/rbutil/rbutilqt/base/bootloaderinstalls5l.cpp index e8852d6df5..3621a27e26 100644 --- a/rbutil/rbutilqt/base/bootloaderinstalls5l.cpp +++ b/rbutil/rbutilqt/base/bootloaderinstalls5l.cpp | |||
@@ -23,7 +23,7 @@ | |||
23 | #include "utils.h" | 23 | #include "utils.h" |
24 | #include "system.h" | 24 | #include "system.h" |
25 | #include "rbsettings.h" | 25 | #include "rbsettings.h" |
26 | #include "systeminfo.h" | 26 | #include "playerbuildinfo.h" |
27 | 27 | ||
28 | #include "../mks5lboot/mks5lboot.h" | 28 | #include "../mks5lboot/mks5lboot.h" |
29 | 29 | ||
@@ -408,8 +408,8 @@ BootloaderInstallBase::BootloaderType BootloaderInstallS5l::installed(void) | |||
408 | QString logfile = RbSettings::value(RbSettings::Mountpoint).toString() | 408 | QString logfile = RbSettings::value(RbSettings::Mountpoint).toString() |
409 | + "/.rockbox/rbutil.log"; | 409 | + "/.rockbox/rbutil.log"; |
410 | QSettings s(logfile, QSettings::IniFormat, this); | 410 | QSettings s(logfile, QSettings::IniFormat, this); |
411 | QString section = SystemInfo::platformValue( | 411 | QString section = PlayerBuildInfo::instance()->value( |
412 | SystemInfo::BootloaderName).toString().section('/', -1); | 412 | PlayerBuildInfo::BootloaderName).toString().section('/', -1); |
413 | rbblInstalled = s.contains("Bootloader/" + section); | 413 | rbblInstalled = s.contains("Bootloader/" + section); |
414 | 414 | ||
415 | if (rbblInstalled) { | 415 | if (rbblInstalled) { |