summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2021-07-24 15:39:01 +0100
committerAidan MacDonald <amachronic@protonmail.com>2021-08-04 18:59:46 +0000
commit005c414e5f2a0ace3756da767d3920ac98cb5c76 (patch)
tree73b17f1e733ffb64a475657eefa21b17ac1ff7b9 /lib
parentef41cc6623226f3ce7630211ef88640a48fb8e59 (diff)
downloadrockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.tar.gz
rockbox-005c414e5f2a0ace3756da767d3920ac98cb5c76.zip
Document intentional fallthroughs + fix harmless unintended ones
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
Diffstat (limited to 'lib')
-rw-r--r--lib/rbcodec/codecs/liba52/downmix.c3
-rw-r--r--lib/rbcodec/dsp/crossfeed.c1
2 files changed, 4 insertions, 0 deletions
diff --git a/lib/rbcodec/codecs/liba52/downmix.c b/lib/rbcodec/codecs/liba52/downmix.c
index dd2867cb92..277b04d4c8 100644
--- a/lib/rbcodec/codecs/liba52/downmix.c
+++ b/lib/rbcodec/codecs/liba52/downmix.c
@@ -498,6 +498,7 @@ void a52_downmix (sample_t * samples, int acmod, int output,
498 case CONVERT (A52_2F1R, A52_MONO): 498 case CONVERT (A52_2F1R, A52_MONO):
499 if (slev == 0) 499 if (slev == 0)
500 goto mix_2to1; 500 goto mix_2to1;
501 /* fallthrough */
501 case CONVERT (A52_3F, A52_MONO): 502 case CONVERT (A52_3F, A52_MONO):
502 mix_3to1: 503 mix_3to1:
503 mix3to1 (samples); 504 mix3to1 (samples);
@@ -506,9 +507,11 @@ void a52_downmix (sample_t * samples, int acmod, int output,
506 case CONVERT (A52_3F1R, A52_MONO): 507 case CONVERT (A52_3F1R, A52_MONO):
507 if (slev == 0) 508 if (slev == 0)
508 goto mix_3to1; 509 goto mix_3to1;
510 /* fallthrough */
509 case CONVERT (A52_2F2R, A52_MONO): 511 case CONVERT (A52_2F2R, A52_MONO):
510 if (slev == 0) 512 if (slev == 0)
511 goto mix_2to1; 513 goto mix_2to1;
514 /* fallthrough */
512 mix4to1 (samples); 515 mix4to1 (samples);
513 break; 516 break;
514 517
diff --git a/lib/rbcodec/dsp/crossfeed.c b/lib/rbcodec/dsp/crossfeed.c
index 60f38b243c..9cca7d8973 100644
--- a/lib/rbcodec/dsp/crossfeed.c
+++ b/lib/rbcodec/dsp/crossfeed.c
@@ -334,6 +334,7 @@ static intptr_t crossfeed_configure(struct dsp_proc_entry *this,
334 case DSP_PROC_INIT: 334 case DSP_PROC_INIT:
335 if (value == 0) 335 if (value == 0)
336 this->data = (intptr_t)&crossfeed_state; 336 this->data = (intptr_t)&crossfeed_state;
337 /* Fallthrough */
337 338
338 case DSP_SET_OUT_FREQUENCY: 339 case DSP_SET_OUT_FREQUENCY:
339 update_process_fn(this, dsp); 340 update_process_fn(this, dsp);