diff options
author | William Wilgus <wilgus.william@gmail.com> | 2024-07-05 17:13:10 -0400 |
---|---|---|
committer | William Wilgus <me.theuser@yahoo.com> | 2024-07-09 01:40:02 -0400 |
commit | fdbaf7df597b404be04cecbdc83dbc0551a5b996 (patch) | |
tree | f4254d2ed63ce1174d9710a315678aeaf921399b /lib/rbcodec/metadata/metadata.h | |
parent | 07cf87419189f8730eff53bb74669856a42a2016 (diff) | |
download | rockbox-fdbaf7df597b404be04cecbdc83dbc0551a5b996.tar.gz rockbox-fdbaf7df597b404be04cecbdc83dbc0551a5b996.zip |
[Feature] playlist_viewer id3 title display
Not sure this is a great idea from disk and battery standpoint
but there is no reason you can't..
using the name buffer to fill title data
prevent hitting the disk for each screen scroll
add get_metadata_ex to allow flags
METADATA_EXCLUDE_ID3_PATH
prevent copying the filename to the ID3 struct
METADATA_CLOSE_FD_ON_EXIT
instead of seeking to the beginning the file is closed before
get_metadata returns
add logic to allow a invalid fd to signal that get_metadata
should open and close the file within its call
bugfix per Chris_s don't use the tagcache for the trackinfo
Change-Id: Ic7a595b39a8d7a57f975312bc9c8bb4111f22a88
Diffstat (limited to 'lib/rbcodec/metadata/metadata.h')
-rw-r--r-- | lib/rbcodec/metadata/metadata.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/rbcodec/metadata/metadata.h b/lib/rbcodec/metadata/metadata.h index b30979334a..a0ba0376c6 100644 --- a/lib/rbcodec/metadata/metadata.h +++ b/lib/rbcodec/metadata/metadata.h | |||
@@ -24,6 +24,8 @@ | |||
24 | 24 | ||
25 | #include "platform.h" | 25 | #include "platform.h" |
26 | 26 | ||
27 | #define METADATA_EXCLUDE_ID3_PATH (0x01) /* don't copy filename path to the id3 path buffer */ | ||
28 | #define METADATA_CLOSE_FD_ON_EXIT (0x02) /* close the filedescriptor when finished */ | ||
27 | /* Audio file types. */ | 29 | /* Audio file types. */ |
28 | /* NOTE: The values of the AFMT_* items are used for the %fc tag in the WPS | 30 | /* NOTE: The values of the AFMT_* items are used for the %fc tag in the WPS |
29 | - so new entries MUST be added to the end to maintain compatibility. | 31 | - so new entries MUST be added to the end to maintain compatibility. |
@@ -323,6 +325,7 @@ struct mp3entry { | |||
323 | 325 | ||
324 | unsigned int probe_file_format(const char *filename); | 326 | unsigned int probe_file_format(const char *filename); |
325 | bool get_metadata(struct mp3entry* id3, int fd, const char* trackname); | 327 | bool get_metadata(struct mp3entry* id3, int fd, const char* trackname); |
328 | bool get_metadata_ex(struct mp3entry* id3, int fd, const char* trackname, int flags); | ||
326 | bool mp3info(struct mp3entry *entry, const char *filename); | 329 | bool mp3info(struct mp3entry *entry, const char *filename); |
327 | void adjust_mp3entry(struct mp3entry *entry, void *dest, const void *orig); | 330 | void adjust_mp3entry(struct mp3entry *entry, void *dest, const void *orig); |
328 | void copy_mp3entry(struct mp3entry *dest, const struct mp3entry *orig); | 331 | void copy_mp3entry(struct mp3entry *dest, const struct mp3entry *orig); |