Now charcell displays require lcd_update() for updating the main lcd content like bitmap displays.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13050 a1c6a512-1295-4272-9138-f99709370657

3 files changed, 1 insertions, 14 deletions

diff --git a/firmware/drivers/lcd-charcell.c b/firmware/drivers/lcd-charcell.c
index 8219a0b317..efc9aa5b1f 100644
--- a/firmware/drivers/lcd-charcell.c
+++ b/firmware/drivers/lcd-charcell.c
@@ -295,10 +295,7 @@ void lcd_define_pattern(unsigned long ucs, const char *pattern)
         memcpy(xfont_variable[glyph & 0x7fff], pattern, HW_PATTERN_SIZE);
         pat = glyph_to_pat(glyph);
         if (pat != NO_PATTERN)
-        {
             memcpy(lcd_patterns[pat].pattern, pattern, HW_PATTERN_SIZE);
-            lcd_update(); //FIXME: remove when lcd_update() calls are checked all over
-        }
     }
 }
 
@@ -315,8 +312,6 @@ void lcd_clear_display(void)
     for (x = 0; x < LCD_WIDTH; x++)
         for (y = 0; y < LCD_HEIGHT; y++)
             lcd_putxchar(x, y, xspace);
-
-    lcd_update(); //FIXME: remove when lcd_update() calls are checked all over
 }
 
 /* Put an unicode character at the given position */
@@ -326,7 +321,6 @@ void lcd_putc(int x, int y, unsigned long ucs)
         return;
 
     lcd_putxchar(x, y, find_xchar(ucs));
-    lcd_update(); //FIXME: remove when lcd_update() calls are checked all over
 }
 
 /* Show cursor (alternating with existing character) at the given position */
@@ -384,7 +378,6 @@ void lcd_putsxy(int x, int y, const unsigned char *str)
         return;
 
     lcd_putsxyofs(x, y, 0, str);
-    lcd_update(); //FIXME: remove when lcd_update() calls are checked all over
 }
 
 /*** Line oriented text output ***/
@@ -410,8 +403,6 @@ void lcd_puts_offset(int x, int y, const unsigned char *str, int offset)
     x = lcd_putsxyofs(x, y, offset, str);
     while (x < LCD_WIDTH)
         lcd_putxchar(x++, y, xspace);
-
-    lcd_update(); //FIXME: remove when lcd_update() calls are checked all over
 }
 
 /** scrolling **/
diff --git a/firmware/panic.c b/firmware/panic.c
index c50bd54457..f9d1cd3083 100644
--- a/firmware/panic.c
+++ b/firmware/panic.c
@@ -74,11 +74,10 @@ void panicf( const char *fmt, ...)
             panic_buf[i+18] = c;
         }
     }
-    lcd_update();
-
 #else
     /* no LCD */
 #endif
+    lcd_update();
     DEBUGF(panic_buf);
 
     set_cpu_frequency(0);
diff --git a/firmware/system.c b/firmware/system.c
index f8fd73d11d..02d14e3ee6 100644
--- a/firmware/system.c
+++ b/firmware/system.c
@@ -452,10 +452,7 @@ void UIE (unsigned int pc) /* Unexpected Interrupt or Exception */
     lcd_puts(0,0,str);
     snprintf(str,sizeof(str),"at %08x",pc);
     lcd_puts(0,1,str);
-
-#ifdef HAVE_LCD_BITMAP
     lcd_update ();
-#endif
 
     while (1)
     {