diff options
author | Daniel Stenberg <daniel@haxx.se> | 2002-05-08 07:10:16 +0000 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2002-05-08 07:10:16 +0000 |
commit | af5c607832b9c6b2a5a9ff34e6550c5cdb5cd8c9 (patch) | |
tree | 18f9c1c9422c96d49f2c9650f398286b20456e31 /firmware | |
parent | bdc3ff0b084ce46cbdcfb14d16e1a915f8092fd7 (diff) | |
download | rockbox-af5c607832b9c6b2a5a9ff34e6550c5cdb5cd8c9.tar.gz rockbox-af5c607832b9c6b2a5a9ff34e6550c5cdb5cd8c9.zip |
uninitialised variable and better return code check
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@504 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware')
-rw-r--r-- | firmware/id3.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/firmware/id3.c b/firmware/id3.c index c83178ad4b..f41be09405 100644 --- a/firmware/id3.c +++ b/firmware/id3.c | |||
@@ -176,7 +176,9 @@ setid3v2title(int fd, mp3entry *entry) | |||
176 | 176 | ||
177 | /* Check version */ | 177 | /* Check version */ |
178 | lseek(fd, 0, SEEK_SET); | 178 | lseek(fd, 0, SEEK_SET); |
179 | read(fd, header, 10); | 179 | if(10 != read(fd, header, 10)) |
180 | return; | ||
181 | |||
180 | version = (unsigned short int)header[3]; | 182 | version = (unsigned short int)header[3]; |
181 | 183 | ||
182 | /* Read all frames in the tag */ | 184 | /* Read all frames in the tag */ |
@@ -348,7 +350,7 @@ getid3v1len(int fd) | |||
348 | static int | 350 | static int |
349 | getsonglength(int fd, mp3entry *entry) | 351 | getsonglength(int fd, mp3entry *entry) |
350 | { | 352 | { |
351 | long header; | 353 | long header=0; |
352 | int version; | 354 | int version; |
353 | int layer; | 355 | int layer; |
354 | int bitindex; | 356 | int bitindex; |