mpegplayer: Make playback engine fully seekable and frame-accurate and split into logical parts. Be sure to have all current features work. Actual UI for seeking will be added soon. Recommended GOP size is about 15-30 frames depending on target or seeking can be slow with really long GOPs (nature of MPEG video). More refined encoding recommendations for a particular player should be posted soon.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15977 a1c6a512-1295-4272-9138-f99709370657

3 files changed, 19 insertions, 7 deletions

diff --git a/firmware/export/system.h b/firmware/export/system.h
index cba4b81631..b973b57fd9 100644
--- a/firmware/export/system.h
+++ b/firmware/export/system.h
@@ -243,16 +243,18 @@ static inline uint32_t swap_odd_even32(uint32_t value)
 #define CACHEALIGN_DOWN(x) \
     ((typeof (x))ALIGN_DOWN_P2((uintptr_t)(x), CACHEALIGN_BITS))
 /* Aligns at least to the greater of size x or CACHEALIGN_SIZE */
-#define CACHEALIGN_AT_LEAST_ATTR(x) __attribute__((aligned(CACHEALIGN_UP(x))))
+#define CACHEALIGN_AT_LEAST_ATTR(x) \
+    __attribute__((aligned(CACHEALIGN_UP(x))))
 /* Aligns a buffer pointer and size to proper boundaries */
 #define CACHEALIGN_BUFFER(start, size) \
-    ({ align_buffer((start), (size), CACHEALIGN_SIZE); })
+    ({ align_buffer(PUN_PTR(void **, (start)), (size), CACHEALIGN_SIZE); })
 
 #else /* ndef PROC_NEEDS_CACHEALIGN */
 
 /* Cache alignment attributes and sizes are not enabled */
 #define CACHEALIGN_ATTR
-#define CACHEALIGN_AT_LEAST_ATTR(x) __attribute__((aligned(x)))
+#define CACHEALIGN_AT_LEAST_ATTR(x) \
+    __attribute__((aligned(x)))
 #define CACHEALIGN_UP(x) (x)
 #define CACHEALIGN_DOWN(x) (x)
 /* Make no adjustments */
@@ -261,4 +263,8 @@ static inline uint32_t swap_odd_even32(uint32_t value)
 
 #endif /* PROC_NEEDS_CACHEALIGN */
 
+/* Double-cast to avoid 'dereferencing type-punned pointer will
+ * break strict aliasing rules' B.S. */
+#define PUN_PTR(type, p) ((type)(intptr_t)(p))
+
 #endif /* __SYSTEM_H__ */
diff --git a/firmware/export/thread.h b/firmware/export/thread.h
index df18f7b095..0b1500cd99 100644
--- a/firmware/export/thread.h
+++ b/firmware/export/thread.h
@@ -42,11 +42,20 @@
 #define PRIORITY_SYSTEM          6   /* All other firmware threads */
 #define PRIORITY_BACKGROUND      8   /* Normal application threads */
 
+/* TODO: Only a minor tweak to create_thread would be needed to let
+ * thread slots be caller allocated - no essential threading functionality
+ * depends upon an array */
 #if CONFIG_CODEC == SWCODEC
+
+#ifdef HAVE_RECORDING
+#define MAXTHREADS  18
+#else
 #define MAXTHREADS  17
+#endif
+
 #else
 #define MAXTHREADS  11
-#endif
+#endif /* CONFIG_CODE == * */
 
 #define DEFAULT_STACK_SIZE 0x400 /* Bytes */
 
diff --git a/firmware/general.c b/firmware/general.c
index cc3710c8f3..117e6c3548 100644
--- a/firmware/general.c
+++ b/firmware/general.c
@@ -77,8 +77,6 @@ int make_list_from_caps32(unsigned long src_mask,
     return count;
 } /* make_list_from_caps32 */
 
-/* Only needed for cache aligning atm */
-#ifdef PROC_NEEDS_CACHEALIGN
 /* Align a buffer and size to a size boundary while remaining within
  * the original boundaries */
 size_t align_buffer(void **start, size_t size, size_t align)
@@ -98,4 +96,3 @@ size_t align_buffer(void **start, size_t size, size_t align)
     *start = newstart;
     return newend - newstart;
 }
-#endif /* PROC_NEEDS_CACHEALIGN */