diff options
author | William Wilgus <wilgus.william@gmail.com> | 2024-09-11 22:36:42 -0400 |
---|---|---|
committer | William Wilgus <me.theuser@yahoo.com> | 2024-09-12 19:16:02 -0400 |
commit | 79bed1f422a79a18e40443b9ada647aeb1c0cc61 (patch) | |
tree | f9fe9e18e54c379bc67ded5e9569d43e799c580f /firmware | |
parent | 2a0f3c8276c397b384ffa8b57fa62f38f3cea6a9 (diff) | |
download | rockbox-79bed1f422a79a18e40443b9ada647aeb1c0cc61.tar.gz rockbox-79bed1f422a79a18e40443b9ada647aeb1c0cc61.zip |
RFC skin_tokens remove a static buffer
it was hard to hit this branch, I had to comment out:
ln 555 else if (offset == 1)
ln 556 pid3 = state->nid3;
as far as I can tell the reason for the separate filename buffer
was due to the failure mode of audio_peek_track() wiping
the id3->path, stands to reason for me that we can just fill it
again
-Already found a gotcha playlist_peek() mutates the buffer
makes me like this solution less, might rework tagcache_fill_tags()
instead
--Fixed
Change-Id: I4a2ee71a8e2d0739c9e141948b71c2ed36296e3b
Diffstat (limited to 'firmware')
0 files changed, 0 insertions, 0 deletions