diff options
author | Jens Arnold <amiconn@rockbox.org> | 2007-02-18 10:07:27 +0000 |
---|---|---|
committer | Jens Arnold <amiconn@rockbox.org> | 2007-02-18 10:07:27 +0000 |
commit | 3a37f46fc92fe7f9846a4077cc1a985c500d1174 (patch) | |
tree | 76541ae462f02ede816ab3f9b42f5207f068658c /firmware | |
parent | da88e84f482c8c96c0d64bf67969b6e9dd9a8379 (diff) | |
download | rockbox-3a37f46fc92fe7f9846a4077cc1a985c500d1174.tar.gz rockbox-3a37f46fc92fe7f9846a4077cc1a985c500d1174.zip |
Fix CONFIG_BACKLIGHT warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12393 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware')
-rw-r--r-- | firmware/backlight.c | 8 | ||||
-rw-r--r-- | firmware/drivers/button.c | 14 | ||||
-rw-r--r-- | firmware/export/backlight.h | 4 | ||||
-rw-r--r-- | firmware/export/button.h | 3 | ||||
-rw-r--r-- | firmware/export/config.h | 4 | ||||
-rw-r--r-- | firmware/powermgmt.c | 2 |
6 files changed, 19 insertions, 16 deletions
diff --git a/firmware/backlight.c b/firmware/backlight.c index 99da3df0a8..a273b94a38 100644 --- a/firmware/backlight.c +++ b/firmware/backlight.c | |||
@@ -90,7 +90,7 @@ static inline void __backlight_off(void) | |||
90 | #endif | 90 | #endif |
91 | #endif /* SIMULATOR */ | 91 | #endif /* SIMULATOR */ |
92 | 92 | ||
93 | #if defined(CONFIG_BACKLIGHT) && !defined(BOOTLOADER) | 93 | #if CONFIG_BACKLIGHT && !defined(BOOTLOADER) |
94 | 94 | ||
95 | const signed char backlight_timeout_value[19] = | 95 | const signed char backlight_timeout_value[19] = |
96 | { | 96 | { |
@@ -804,10 +804,10 @@ void backlight_set_brightness(int val) | |||
804 | } | 804 | } |
805 | #endif /* HAVE_BACKLIGHT_BRIGHTNESS */ | 805 | #endif /* HAVE_BACKLIGHT_BRIGHTNESS */ |
806 | 806 | ||
807 | #else /* !defined(CONFIG_BACKLIGHT) || defined(BOOTLOADER) | 807 | #else /* (CONFIG_BACKLIGHT == 0) || defined(BOOTLOADER) |
808 | -- no backlight, empty dummy functions */ | 808 | -- no backlight, empty dummy functions */ |
809 | 809 | ||
810 | #if defined(BOOTLOADER) && defined(CONFIG_BACKLIGHT) | 810 | #if defined(BOOTLOADER) && CONFIG_BACKLIGHT |
811 | void backlight_init(void) | 811 | void backlight_init(void) |
812 | { | 812 | { |
813 | #ifdef __BACKLIGHT_INIT | 813 | #ifdef __BACKLIGHT_INIT |
@@ -830,4 +830,4 @@ bool is_remote_backlight_on(void) {return true;} | |||
830 | #ifdef HAVE_BACKLIGHT_BRIGHTNESS | 830 | #ifdef HAVE_BACKLIGHT_BRIGHTNESS |
831 | void backlight_set_brightness(int val) { (void)val; } | 831 | void backlight_set_brightness(int val) { (void)val; } |
832 | #endif | 832 | #endif |
833 | #endif /* defined(CONFIG_BACKLIGHT) && !defined(BOOTLOADER) */ | 833 | #endif /* CONFIG_BACKLIGHT && !defined(BOOTLOADER) */ |
diff --git a/firmware/drivers/button.c b/firmware/drivers/button.c index 5a40bdfde0..a1fd58c447 100644 --- a/firmware/drivers/button.c +++ b/firmware/drivers/button.c | |||
@@ -43,7 +43,7 @@ static long last_read; /* Last button status, for debouncing/filtering */ | |||
43 | #ifdef HAVE_LCD_BITMAP | 43 | #ifdef HAVE_LCD_BITMAP |
44 | static bool flipped; /* buttons can be flipped to match the LCD flip */ | 44 | static bool flipped; /* buttons can be flipped to match the LCD flip */ |
45 | #endif | 45 | #endif |
46 | #ifdef CONFIG_BACKLIGHT | 46 | #if CONFIG_BACKLIGHT |
47 | static bool filter_first_keypress; | 47 | static bool filter_first_keypress; |
48 | #ifdef HAVE_REMOTE_LCD | 48 | #ifdef HAVE_REMOTE_LCD |
49 | static bool remote_filter_first_keypress; | 49 | static bool remote_filter_first_keypress; |
@@ -71,7 +71,7 @@ static void button_tick(void) | |||
71 | static int repeat_count = 0; | 71 | static int repeat_count = 0; |
72 | static bool repeat = false; | 72 | static bool repeat = false; |
73 | static bool post = false; | 73 | static bool post = false; |
74 | #ifdef CONFIG_BACKLIGHT | 74 | #if CONFIG_BACKLIGHT |
75 | static bool skip_release = false; | 75 | static bool skip_release = false; |
76 | #ifdef HAVE_REMOTE_LCD | 76 | #ifdef HAVE_REMOTE_LCD |
77 | static bool skip_remote_release = false; | 77 | static bool skip_remote_release = false; |
@@ -112,7 +112,7 @@ static void button_tick(void) | |||
112 | diff = btn ^ lastbtn; | 112 | diff = btn ^ lastbtn; |
113 | if(diff && (btn & diff) == 0) | 113 | if(diff && (btn & diff) == 0) |
114 | { | 114 | { |
115 | #ifdef CONFIG_BACKLIGHT | 115 | #if CONFIG_BACKLIGHT |
116 | #ifdef HAVE_REMOTE_LCD | 116 | #ifdef HAVE_REMOTE_LCD |
117 | if(diff & BUTTON_REMOTE) | 117 | if(diff & BUTTON_REMOTE) |
118 | if(!skip_remote_release) | 118 | if(!skip_remote_release) |
@@ -202,7 +202,7 @@ static void button_tick(void) | |||
202 | if (queue_empty(&button_queue)) | 202 | if (queue_empty(&button_queue)) |
203 | { | 203 | { |
204 | queue_post(&button_queue, BUTTON_REPEAT | btn, 0); | 204 | queue_post(&button_queue, BUTTON_REPEAT | btn, 0); |
205 | #ifdef CONFIG_BACKLIGHT | 205 | #if CONFIG_BACKLIGHT |
206 | #ifdef HAVE_REMOTE_LCD | 206 | #ifdef HAVE_REMOTE_LCD |
207 | skip_remote_release = false; | 207 | skip_remote_release = false; |
208 | #endif | 208 | #endif |
@@ -213,7 +213,7 @@ static void button_tick(void) | |||
213 | } | 213 | } |
214 | else | 214 | else |
215 | { | 215 | { |
216 | #ifdef CONFIG_BACKLIGHT | 216 | #if CONFIG_BACKLIGHT |
217 | #ifdef HAVE_REMOTE_LCD | 217 | #ifdef HAVE_REMOTE_LCD |
218 | if (btn & BUTTON_REMOTE) { | 218 | if (btn & BUTTON_REMOTE) { |
219 | if (!remote_filter_first_keypress || is_remote_backlight_on() | 219 | if (!remote_filter_first_keypress || is_remote_backlight_on() |
@@ -288,7 +288,7 @@ void button_init(void) | |||
288 | #ifdef HAVE_LCD_BITMAP | 288 | #ifdef HAVE_LCD_BITMAP |
289 | flipped = false; | 289 | flipped = false; |
290 | #endif | 290 | #endif |
291 | #ifdef CONFIG_BACKLIGHT | 291 | #if CONFIG_BACKLIGHT |
292 | filter_first_keypress = false; | 292 | filter_first_keypress = false; |
293 | #ifdef HAVE_REMOTE_LCD | 293 | #ifdef HAVE_REMOTE_LCD |
294 | remote_filter_first_keypress = false; | 294 | remote_filter_first_keypress = false; |
@@ -360,7 +360,7 @@ void button_set_flip(bool flip) | |||
360 | } | 360 | } |
361 | #endif /* HAVE_LCD_BITMAP */ | 361 | #endif /* HAVE_LCD_BITMAP */ |
362 | 362 | ||
363 | #ifdef CONFIG_BACKLIGHT | 363 | #if CONFIG_BACKLIGHT |
364 | void set_backlight_filter_keypress(bool value) | 364 | void set_backlight_filter_keypress(bool value) |
365 | { | 365 | { |
366 | filter_first_keypress = value; | 366 | filter_first_keypress = value; |
diff --git a/firmware/export/backlight.h b/firmware/export/backlight.h index 1cd6c47f36..2873666dd8 100644 --- a/firmware/export/backlight.h +++ b/firmware/export/backlight.h | |||
@@ -26,7 +26,7 @@ void backlight_on(void); | |||
26 | void backlight_off(void); | 26 | void backlight_off(void); |
27 | void backlight_set_timeout(int index); | 27 | void backlight_set_timeout(int index); |
28 | 28 | ||
29 | #ifdef CONFIG_BACKLIGHT | 29 | #if CONFIG_BACKLIGHT |
30 | void backlight_init(void); | 30 | void backlight_init(void); |
31 | 31 | ||
32 | #if defined(IAUDIO_X5) && !defined(SIMULATOR) | 32 | #if defined(IAUDIO_X5) && !defined(SIMULATOR) |
@@ -54,7 +54,7 @@ void lcd_set_sleep_after_backlight_off(int index); | |||
54 | extern const signed char lcd_sleep_timeout_value[]; | 54 | extern const signed char lcd_sleep_timeout_value[]; |
55 | #endif | 55 | #endif |
56 | 56 | ||
57 | #else /* ndef CONFIG_BACKLIGHT */ | 57 | #else /* CONFIG_BACKLIGHT == 0 */ |
58 | #define backlight_init() | 58 | #define backlight_init() |
59 | #endif /* CONFIG_BACKLIGHT */ | 59 | #endif /* CONFIG_BACKLIGHT */ |
60 | 60 | ||
diff --git a/firmware/export/button.h b/firmware/export/button.h index 102d542d27..ea3effcaba 100644 --- a/firmware/export/button.h +++ b/firmware/export/button.h | |||
@@ -1,4 +1,3 @@ | |||
1 | |||
2 | /*************************************************************************** | 1 | /*************************************************************************** |
3 | * __________ __ ___. | 2 | * __________ __ ___. |
4 | * Open \______ \ ____ ____ | | _\_ |__ _______ ___ | 3 | * Open \______ \ ____ ____ | | _\_ |__ _______ ___ |
@@ -34,7 +33,7 @@ void button_clear_queue(void); | |||
34 | #ifdef HAVE_LCD_BITMAP | 33 | #ifdef HAVE_LCD_BITMAP |
35 | void button_set_flip(bool flip); /* turn 180 degrees */ | 34 | void button_set_flip(bool flip); /* turn 180 degrees */ |
36 | #endif | 35 | #endif |
37 | #ifdef CONFIG_BACKLIGHT | 36 | #if CONFIG_BACKLIGHT |
38 | void set_backlight_filter_keypress(bool value); | 37 | void set_backlight_filter_keypress(bool value); |
39 | #ifdef HAVE_REMOTE_LCD | 38 | #ifdef HAVE_REMOTE_LCD |
40 | void set_remote_backlight_filter_keypress(bool value); | 39 | void set_remote_backlight_filter_keypress(bool value); |
diff --git a/firmware/export/config.h b/firmware/export/config.h index 8283b37fc8..1a3e0be325 100644 --- a/firmware/export/config.h +++ b/firmware/export/config.h | |||
@@ -230,6 +230,10 @@ | |||
230 | #define CONFIG_LED 0 | 230 | #define CONFIG_LED 0 |
231 | #endif | 231 | #endif |
232 | 232 | ||
233 | #ifndef CONFIG_BACKLIGHT | ||
234 | #define CONFIG_BACKLIGHT 0 | ||
235 | #endif | ||
236 | |||
233 | #ifndef CONFIG_CHARGING | 237 | #ifndef CONFIG_CHARGING |
234 | #define CONFIG_CHARGING 0 | 238 | #define CONFIG_CHARGING 0 |
235 | #endif | 239 | #endif |
diff --git a/firmware/powermgmt.c b/firmware/powermgmt.c index a31acbcf0b..1a1d576e67 100644 --- a/firmware/powermgmt.c +++ b/firmware/powermgmt.c | |||
@@ -702,7 +702,7 @@ static int runcurrent(void) | |||
702 | current = CURRENT_USB; | 702 | current = CURRENT_USB; |
703 | } | 703 | } |
704 | 704 | ||
705 | #if defined(CONFIG_BACKLIGHT) && !defined(BOOTLOADER) | 705 | #if CONFIG_BACKLIGHT && !defined(BOOTLOADER) |
706 | if (backlight_get_current_timeout() == 0) /* LED always on */ | 706 | if (backlight_get_current_timeout() == 0) /* LED always on */ |
707 | current += CURRENT_BACKLIGHT; | 707 | current += CURRENT_BACKLIGHT; |
708 | #endif | 708 | #endif |