diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/tuner.c | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/tuner.c')
-rw-r--r-- | firmware/tuner.c | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/firmware/tuner.c b/firmware/tuner.c index c9c5bc0639..565850c659 100644 --- a/firmware/tuner.c +++ b/firmware/tuner.c | |||
@@ -24,6 +24,9 @@ | |||
24 | #include "kernel.h" | 24 | #include "kernel.h" |
25 | #include "tuner.h" | 25 | #include "tuner.h" |
26 | #include "fmradio.h" | 26 | #include "fmradio.h" |
27 | #ifdef HAVE_RDS_CAP | ||
28 | #include "rds.h" | ||
29 | #endif /* HAVE_RDS_CAP */ | ||
27 | 30 | ||
28 | /* General region information */ | 31 | /* General region information */ |
29 | const struct fm_region_data fm_region_data[TUNER_NUM_REGIONS] = | 32 | const struct fm_region_data fm_region_data[TUNER_NUM_REGIONS] = |
@@ -102,4 +105,24 @@ void tuner_init(void) | |||
102 | #endif | 105 | #endif |
103 | } | 106 | } |
104 | } | 107 | } |
108 | |||
109 | #ifdef HAVE_RDS_CAP | ||
110 | size_t tuner_get_rds_info(int setting, void *dst, size_t dstsize) | ||
111 | { | ||
112 | /* TODO: integrate this into tuner_get/set */ | ||
113 | static const unsigned char info_id_tbl[] = | ||
114 | { | ||
115 | [RADIO_RDS_NAME] = RDS_INFO_PS, | ||
116 | [RADIO_RDS_TEXT] = RDS_INFO_RT, | ||
117 | [RADIO_RDS_PROGRAM_INFO] = RDS_INFO_PI, | ||
118 | [RADIO_RDS_CURRENT_TIME] = RDS_INFO_CT, | ||
119 | }; | ||
120 | |||
121 | if ((unsigned int)setting >= ARRAYLEN(info_id_tbl)) | ||
122 | return 0; | ||
123 | |||
124 | return rds_pull_info(info_id_tbl[setting], (uintptr_t)dst, dstsize); | ||
125 | } | ||
126 | #endif /* HAVE_RDS_CAP */ | ||
127 | |||
105 | #endif /* SIMULATOR */ | 128 | #endif /* SIMULATOR */ |