diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-19 10:54:26 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-20 22:41:29 +0100 |
commit | 672bbe434b12d4730cf270f7245753fb98cf162d (patch) | |
tree | 3fdaa08ddc41f942336c968bb169e8806c7c3fa8 /firmware/target/arm/tms320dm320 | |
parent | 99f333c64f13c3f9a62b9f5e184ae87f053bf65a (diff) | |
download | rockbox-672bbe434b12d4730cf270f7245753fb98cf162d.tar.gz rockbox-672bbe434b12d4730cf270f7245753fb98cf162d.zip |
usb: rename usb_drv_recv() to usb_recv_recv_nonblocking()
IMHO the current name is somewhat misleading:
- usb_drv_send() is blocking and we have usb_drv_send_nonblocking()
for the non-blocking case. This inconsistent naming can only
promote confusion. (And what would we call a blocking receive?)
- Other hardware abstraction APIs in Rockbox are usually blocking:
storage, LCD, backlight, audio... in other words, blocking is the
default expected behavior, with non-blocking calls being a rarity.
Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af
Diffstat (limited to 'firmware/target/arm/tms320dm320')
-rw-r--r-- | firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c b/firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c index 5563a40814..f1acc9c964 100644 --- a/firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c +++ b/firmware/target/arm/tms320dm320/sansa-connect/tnetv105_usb_drv.c | |||
@@ -1026,8 +1026,8 @@ static bool tnetv_handle_cppi(void) | |||
1026 | if (rx_intstatus || tx_intstatus || rcv_sched) | 1026 | if (rx_intstatus || tx_intstatus || rcv_sched) |
1027 | { | 1027 | { |
1028 | /* Request calling again after short delay | 1028 | /* Request calling again after short delay |
1029 | * Needed when for example when OUT endpoint has pending | 1029 | * Needed when for example when OUT endpoint has pending data |
1030 | * data but the USB task did not call usb_drv_recv() yet. | 1030 | * but the USB task did not call usb_drv_recv_nonblocking() yet. |
1031 | */ | 1031 | */ |
1032 | return true; | 1032 | return true; |
1033 | } | 1033 | } |
@@ -1371,7 +1371,7 @@ int usb_drv_send_nonblocking(int endpoint, void* ptr, int length) | |||
1371 | return _usb_drv_send(endpoint, ptr, length, false); | 1371 | return _usb_drv_send(endpoint, ptr, length, false); |
1372 | } | 1372 | } |
1373 | 1373 | ||
1374 | int usb_drv_recv(int endpoint, void* ptr, int length) | 1374 | int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length) |
1375 | { | 1375 | { |
1376 | int epn = EP_NUM(endpoint); | 1376 | int epn = EP_NUM(endpoint); |
1377 | struct ep_runtime_t *ep; | 1377 | struct ep_runtime_t *ep; |
@@ -1388,8 +1388,6 @@ int usb_drv_recv(int endpoint, void* ptr, int length) | |||
1388 | return 0; | 1388 | return 0; |
1389 | } | 1389 | } |
1390 | 1390 | ||
1391 | void usb_drv_ack(struct usb_ctrlrequest* req); | ||
1392 | |||
1393 | void usb_drv_set_address(int address) | 1391 | void usb_drv_set_address(int address) |
1394 | { | 1392 | { |
1395 | UsbCtrlType usbCtrl; | 1393 | UsbCtrlType usbCtrl; |