diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/target/arm/imx233 | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/target/arm/imx233')
-rw-r--r-- | firmware/target/arm/imx233/sansa-fuzeplus/fmradio-i2c-fuzeplus.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/firmware/target/arm/imx233/sansa-fuzeplus/fmradio-i2c-fuzeplus.c b/firmware/target/arm/imx233/sansa-fuzeplus/fmradio-i2c-fuzeplus.c index bc4a83665d..5d146c4846 100644 --- a/firmware/target/arm/imx233/sansa-fuzeplus/fmradio-i2c-fuzeplus.c +++ b/firmware/target/arm/imx233/sansa-fuzeplus/fmradio-i2c-fuzeplus.c | |||
@@ -23,7 +23,6 @@ | |||
23 | #include "system.h" | 23 | #include "system.h" |
24 | #include "kernel.h" | 24 | #include "kernel.h" |
25 | #include "pinctrl-imx233.h" | 25 | #include "pinctrl-imx233.h" |
26 | #include "rds.h" | ||
27 | #include "si4700.h" | 26 | #include "si4700.h" |
28 | 27 | ||
29 | /** | 28 | /** |
@@ -52,13 +51,11 @@ static void stc_rds_callback(int bank, int pin, intptr_t user) | |||
52 | /* Captures RDS data and processes it */ | 51 | /* Captures RDS data and processes it */ |
53 | static void NORETURN_ATTR rds_thread(void) | 52 | static void NORETURN_ATTR rds_thread(void) |
54 | { | 53 | { |
55 | uint16_t rds_data[4]; | ||
56 | |||
57 | while(true) | 54 | while(true) |
58 | { | 55 | { |
59 | semaphore_wait(&rds_sema, TIMEOUT_BLOCK); | 56 | semaphore_wait(&rds_sema, TIMEOUT_BLOCK); |
60 | if(si4700_rds_read_raw(rds_data) && rds_process(rds_data)) | 57 | si4700_rds_process(); |
61 | si4700_rds_set_event(); | 58 | |
62 | /* renable callback */ | 59 | /* renable callback */ |
63 | imx233_pinctrl_setup_irq(2, 27, true, true, false, &stc_rds_callback, 0); | 60 | imx233_pinctrl_setup_irq(2, 27, true, true, false, &stc_rds_callback, 0); |
64 | } | 61 | } |
@@ -86,7 +83,6 @@ void si4700_rds_powerup(bool on) | |||
86 | void si4700_rds_init(void) | 83 | void si4700_rds_init(void) |
87 | { | 84 | { |
88 | semaphore_init(&rds_sema, 1, 0); | 85 | semaphore_init(&rds_sema, 1, 0); |
89 | rds_init(); | ||
90 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" | 86 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" |
91 | IF_PRIO(, PRIORITY_REALTIME) IF_COP(, CPU)); | 87 | IF_PRIO(, PRIORITY_REALTIME) IF_COP(, CPU)); |
92 | } | 88 | } |