diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/target/arm/as3525 | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/target/arm/as3525')
-rw-r--r-- | firmware/target/arm/as3525/fmradio-i2c-as3525.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/firmware/target/arm/as3525/fmradio-i2c-as3525.c b/firmware/target/arm/as3525/fmradio-i2c-as3525.c index ebe7ebeffd..5b629f5ad4 100644 --- a/firmware/target/arm/as3525/fmradio-i2c-as3525.c +++ b/firmware/target/arm/as3525/fmradio-i2c-as3525.c | |||
@@ -35,7 +35,6 @@ | |||
35 | #include "generic_i2c.h" | 35 | #include "generic_i2c.h" |
36 | #include "fmradio_i2c.h" | 36 | #include "fmradio_i2c.h" |
37 | #include "thread.h" | 37 | #include "thread.h" |
38 | #include "rds.h" | ||
39 | 38 | ||
40 | #if defined(SANSA_CLIP) || defined(SANSA_C200V2) | 39 | #if defined(SANSA_CLIP) || defined(SANSA_C200V2) |
41 | #define I2C_SCL_GPIO(x) GPIOB_PIN(x) | 40 | #define I2C_SCL_GPIO(x) GPIOB_PIN(x) |
@@ -203,13 +202,9 @@ void tuner_isr(void) | |||
203 | /* Captures RDS data and processes it */ | 202 | /* Captures RDS data and processes it */ |
204 | static void NORETURN_ATTR rds_thread(void) | 203 | static void NORETURN_ATTR rds_thread(void) |
205 | { | 204 | { |
206 | uint16_t rds_data[4]; | ||
207 | |||
208 | while (true) { | 205 | while (true) { |
209 | semaphore_wait(&rds_sema, TIMEOUT_BLOCK); | 206 | semaphore_wait(&rds_sema, TIMEOUT_BLOCK); |
210 | if (si4700_rds_read_raw(rds_data) && rds_process(rds_data)) { | 207 | si4700_rds_process(); |
211 | si4700_rds_set_event(); | ||
212 | } | ||
213 | } | 208 | } |
214 | } | 209 | } |
215 | 210 | ||
@@ -233,7 +228,6 @@ void si4700_rds_powerup(bool on) | |||
233 | void si4700_rds_init(void) | 228 | void si4700_rds_init(void) |
234 | { | 229 | { |
235 | semaphore_init(&rds_sema, 1, 0); | 230 | semaphore_init(&rds_sema, 1, 0); |
236 | rds_init(); | ||
237 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" | 231 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" |
238 | IF_PRIO(, PRIORITY_REALTIME) IF_COP(, CPU)); | 232 | IF_PRIO(, PRIORITY_REALTIME) IF_COP(, CPU)); |
239 | } | 233 | } |