diff options
author | Thomas Martitz <kugel@rockbox.org> | 2014-03-14 23:15:16 +0100 |
---|---|---|
committer | Thomas Martitz <kugel@rockbox.org> | 2014-03-14 23:36:30 +0100 |
commit | 470989bd708d9a425dbbf2d83b8fcbd0a8d0f488 (patch) | |
tree | f3bef37bc0f8ff7da4beddad9903209ced1bc25a /firmware/logf.c | |
parent | 50f0dd80d660b332a1739e07a630c2cef1b678c6 (diff) | |
download | rockbox-470989bd708d9a425dbbf2d83b8fcbd0a8d0f488.tar.gz rockbox-470989bd708d9a425dbbf2d83b8fcbd0a8d0f488.zip |
events: Rework event subsystem (add_event, send_event) to be more versatile.
add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.
On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).
As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.
This commit also adds some documentation to events.h
Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772
Diffstat (limited to 'firmware/logf.c')
-rw-r--r-- | firmware/logf.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/firmware/logf.c b/firmware/logf.c index a24a635570..ade5458ca9 100644 --- a/firmware/logf.c +++ b/firmware/logf.c | |||
@@ -322,7 +322,7 @@ static int logdiskf_push(void *userp, unsigned char c) | |||
322 | return true; | 322 | return true; |
323 | } | 323 | } |
324 | 324 | ||
325 | static void flush_buffer(void* data); | 325 | static void flush_buffer(void); |
326 | 326 | ||
327 | void _logdiskf(const char* file, const char level, const char *fmt, ...) | 327 | void _logdiskf(const char* file, const char level, const char *fmt, ...) |
328 | { | 328 | { |
@@ -350,9 +350,8 @@ void _logdiskf(const char* file, const char level, const char *fmt, ...) | |||
350 | register_storage_idle_func(flush_buffer); | 350 | register_storage_idle_func(flush_buffer); |
351 | } | 351 | } |
352 | 352 | ||
353 | static void flush_buffer(void* data) | 353 | static void flush_buffer(void) |
354 | { | 354 | { |
355 | (void)data; | ||
356 | int fd; | 355 | int fd; |
357 | if(logdiskfindex < 1) | 356 | if(logdiskfindex < 1) |
358 | return; | 357 | return; |