diff options
| author | Michael Sevakis <jethead71@rockbox.org> | 2017-03-12 20:59:44 -0400 |
|---|---|---|
| committer | Michael Sevakis <jethead71@rockbox.org> | 2017-03-12 21:09:16 -0400 |
| commit | 70c929179b80e0657e31558e34d2bc62e1176564 (patch) | |
| tree | b359577dabe279aa2e3995f7ef57581d583e7218 /firmware/include/file_internal.h | |
| parent | e3081b35cdeb1e568c61369e5b3b15b6e428d3c3 (diff) | |
| download | rockbox-70c929179b80e0657e31558e34d2bc62e1176564.tar.gz rockbox-70c929179b80e0657e31558e34d2bc62e1176564.zip | |
Dircache: Refine name allocation and error handling.
* 8 bits is enough to allow 260 character base names when five
bytes is the minimum indirect storage size (0..255->5..260).
* Don't truncate anything that's too long as that can lead to
bad behavior, simply don't include the offending entry in the
parent.
* Set the .tinyname flag to 1 by default to indicate that
the entry's name doesn't need freeing. Clear it only when
allocating indirect storage.
* Rename some things to help catch all instances
Change-Id: Iff747b624acbb8e03ed26c24afdf0fc715fd9d99
Diffstat (limited to 'firmware/include/file_internal.h')
| -rw-r--r-- | firmware/include/file_internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/firmware/include/file_internal.h b/firmware/include/file_internal.h index bb1236aed1..5893737833 100644 --- a/firmware/include/file_internal.h +++ b/firmware/include/file_internal.h | |||
| @@ -56,7 +56,7 @@ | |||
| 56 | root + 'Music' + 'Artist' + 'Album' + 'Disc N' + filename */ | 56 | root + 'Music' + 'Artist' + 'Album' + 'Disc N' + filename */ |
| 57 | #define STATIC_PATHCOMP_NUM 6 | 57 | #define STATIC_PATHCOMP_NUM 6 |
| 58 | 58 | ||
| 59 | #define MAX_NAME 255 | 59 | #define MAX_COMPNAME 260 |
| 60 | 60 | ||
| 61 | /* unsigned value that will also hold the off_t range we need without | 61 | /* unsigned value that will also hold the off_t range we need without |
| 62 | overflow */ | 62 | overflow */ |