diff options
author | Marcin Bukat <marcin.bukat@gmail.com> | 2014-01-09 21:37:07 +0100 |
---|---|---|
committer | Marcin Bukat <marcin.bukat@gmail.com> | 2014-01-16 10:17:39 +0100 |
commit | 7ab237b025cbb4c25d345604da32e894379c1721 (patch) | |
tree | 92d147029519c55d57db4273066d57b960ad7158 /firmware/include/buflib.h | |
parent | 7f5dce4116bf4e62e0cd3ef16730157e17625e1c (diff) | |
download | rockbox-7ab237b025cbb4c25d345604da32e894379c1721.tar.gz rockbox-7ab237b025cbb4c25d345604da32e894379c1721.zip |
buflib: Add crc field protecting buflib cookie integrity
This should catch the case of buffer misuse which results
in corrupted cookie of next allocation. The check is performed
on move_block() so it may be a bit late.
There is buflib_check_valid() provided which checks the
integrity of all cookies for given context.
On DEBUG build with --sdl-thread this check is carried out
for core_ctx on every context switch to catch problems earlier.
Change-Id: I999d4576084592394e3dbd3bdf0f32935ff5f601
Reviewed-on: http://gerrit.rockbox.org/711
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Diffstat (limited to 'firmware/include/buflib.h')
-rw-r--r-- | firmware/include/buflib.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/firmware/include/buflib.h b/firmware/include/buflib.h index 0b26c04bcd..171ab5bcd7 100644 --- a/firmware/include/buflib.h +++ b/firmware/include/buflib.h | |||
@@ -40,6 +40,7 @@ union buflib_data | |||
40 | struct buflib_callbacks* ops; | 40 | struct buflib_callbacks* ops; |
41 | char* alloc; | 41 | char* alloc; |
42 | union buflib_data *handle; | 42 | union buflib_data *handle; |
43 | uint32_t crc; | ||
43 | }; | 44 | }; |
44 | 45 | ||
45 | struct buflib_context | 46 | struct buflib_context |
@@ -346,4 +347,9 @@ int buflib_get_num_blocks(struct buflib_context *ctx); | |||
346 | */ | 347 | */ |
347 | void buflib_print_block_at(struct buflib_context *ctx, int block_num, | 348 | void buflib_print_block_at(struct buflib_context *ctx, int block_num, |
348 | char* buf, size_t bufsize); | 349 | char* buf, size_t bufsize); |
350 | |||
351 | /** | ||
352 | * Check integrity of given buflib context | ||
353 | */ | ||
354 | void buflib_check_valid(struct buflib_context *ctx); | ||
349 | #endif | 355 | #endif |