diff options
| author | Franklin Wei <franklin@rockbox.org> | 2020-08-08 00:43:05 -0400 |
|---|---|---|
| committer | Solomon Peachy <pizza@shaftnet.org> | 2023-05-17 13:23:14 -0400 |
| commit | 4554b908590e0f033ab76383516f921f92758435 (patch) | |
| tree | 3e61dd71b5f34875f9d6968b0706867b068fb2b5 /firmware/export/disk.h | |
| parent | e232f69214cfe0ad83e8a6051c58ef54754e59bb (diff) | |
| download | rockbox-4554b908590e0f033ab76383516f921f92758435.tar.gz rockbox-4554b908590e0f033ab76383516f921f92758435.zip | |
sdl: fix two bugs in ROCKBOXAUD_PlayAudio()
First was an off-by-one bug in the loop over buffers. The condition was
`i < this->hidden->n_buffers', but should have been <=, not <. This wasn't
a critical issue, because the last iteration would check the currently
playing buffer - an unlikely situation.
The second logic bug would make the code always think it had found an empty
buffer, even when it had not, since `idx' was being unconditionally set
every loop, rendering it unusable for a sentinel value. Fix that.
Change-Id: I137330965d699acf827e59b6aa5c5f9ddf2ca617
Diffstat (limited to 'firmware/export/disk.h')
0 files changed, 0 insertions, 0 deletions