Samsung YP-R0 hosted target code refactoring

As per title this patch aims at splitting common target
code and specific target code in a better way to
support future ports within the same environment
(e.g. Samsung YP-R1 where the Linux and the SoC
are the same, with differences in hardware devices
handling)

Change-Id: I67b4918c46403b184d3d8f42ab5aae7d01037fd0
Reviewed-on: http://gerrit.rockbox.org/409
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Tested-by: Thomas Martitz <kugel@rockbox.org>

1 files changed, 8 insertions, 5 deletions

diff --git a/firmware/export/config/samsungypr0.h b/firmware/export/config/samsungypr0.h
index debe9a3f80..c81fc645bb 100644
--- a/firmware/export/config/samsungypr0.h
+++ b/firmware/export/config/samsungypr0.h
@@ -12,9 +12,6 @@
 
 #define MODEL_NAME   "Samsung YP-R0"
 
-/* Indeed to check that */
-/*TODO: R0 should charge battery automatically, no software stuff to manage that. Just to know about some as3543 registers, that should be set after loading samsung's afe.ko module 
- */
 /*TODO: implement USB data transfer management -> see safe mode script and think a way to implemtent it in the code */
 #define USB_NONE
 
@@ -94,20 +91,26 @@
 #define HAVE_AS3514
 #define HAVE_AS3543
 
+/* We don't have hardware controls */
 #define HAVE_SW_TONE_CONTROLS
 
+/* We have the Si4709, which supports RDS */
 #define CONFIG_TUNER SI4700
 #define HAVE_TUNER_PWR_CTRL
-
 #define HAVE_RDS_CAP
 
 /* Define this for FM radio input available */
 #define HAVE_FMRADIO_IN
 #define INPUT_SRC_CAPS SRC_CAP_FMRADIO
 
-/* We have a GPIO that detects it */
+/* We have a GPIO pin that detects this */
 #define HAVE_HEADPHONE_DETECTION
 
+/* FIXME
+ * Lot of people reports bad battery life and funny charging times.
+ * Check what's going on...
+ */
+
 #define BATTERY_CAPACITY_DEFAULT 600 /* default battery capacity */
 #define BATTERY_CAPACITY_MIN 600  /* min. capacity selectable */
 #define BATTERY_CAPACITY_MAX 600 /* max. capacity selectable */