diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2024-03-30 15:02:22 +0000 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2024-03-31 11:24:07 -0400 |
commit | b0a8cacd1dd11dbf6f8f7b46675d89e5b5b32920 (patch) | |
tree | 0284666ea01de50c01bbc1e43e8e7f8a96283131 /firmware/export/config/samsungyh925.h | |
parent | 7dc8d754a26c88f376d67e63b1da1adf5e770817 (diff) | |
download | rockbox-b0a8cacd1dd11dbf6f8f7b46675d89e5b5b32920.tar.gz rockbox-b0a8cacd1dd11dbf6f8f7b46675d89e5b5b32920.zip |
rolo: simplify parsing scramble header in load_firmware()
The standard load_firmware() function is used on targets which
use the "scramble -add" method for generating Rockbox binaries.
While it tries to be a bit more generic and allows the CRC/data
offsets to be placed anywhere in the file, there are no targets
which actually need this flexibility, because they are all using
plain old "scramble -add".
So we can actually simplify load_firmware() and remove defines
from the target headers. All the targets used CRC offset = 0 and
data offset = 8, except for a few which I assume never supported
ROLO or were never tested -- eg. samsungyh820: the CRC and data
offsets cannot both be 0.
The actual motivation for this is removing the calls to lseek(),
which can help make bootloaders a tiny bit smaller, as lseek is
typically not used anywhere else in bootloaders.
Change-Id: Ic2d01e5b75a32e88363f085e3e839146a0710bf4
Diffstat (limited to 'firmware/export/config/samsungyh925.h')
-rw-r--r-- | firmware/export/config/samsungyh925.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/firmware/export/config/samsungyh925.h b/firmware/export/config/samsungyh925.h index 8e467550d8..cb6f185014 100644 --- a/firmware/export/config/samsungyh925.h +++ b/firmware/export/config/samsungyh925.h | |||
@@ -184,12 +184,6 @@ | |||
184 | #define BOOTFILE "rockbox." BOOTFILE_EXT | 184 | #define BOOTFILE "rockbox." BOOTFILE_EXT |
185 | #define BOOTDIR "/.rockbox" | 185 | #define BOOTDIR "/.rockbox" |
186 | 186 | ||
187 | /* Offset ( in the firmware file's header ) to the file CRC */ | ||
188 | #define FIRMWARE_OFFSET_FILE_CRC 0x00 | ||
189 | |||
190 | /* Offset ( in the firmware file's header ) to the real data */ | ||
191 | #define FIRMWARE_OFFSET_FILE_DATA 0x00 | ||
192 | |||
193 | #define ICODE_ATTR_TREMOR_NOT_MDCT | 187 | #define ICODE_ATTR_TREMOR_NOT_MDCT |
194 | 188 | ||
195 | 189 | ||