* changes to ata.c - idle callbacks are called after 2 sec of real idle,

and shutdown and usb (it makes sense here). ata_sleep doesnt get broken
by callbacks.
* allow ata_sleep() at the end of buffering again
* config block uses ata_idle instead of delayed sector when saving
* remove delayed sector code from ata_mmc.c (idle callbacks are not yet
implemented for ata_mmc.c tho)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11461 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 19 insertions, 5 deletions

diff --git a/firmware/export/ata_idle_notify.h b/firmware/export/ata_idle_notify.h
index f5f2a25fd9..491a612bdd 100644
--- a/firmware/export/ata_idle_notify.h
+++ b/firmware/export/ata_idle_notify.h
@@ -20,22 +20,36 @@
 #define __ATACALLBACK_H__
 
 #include <stdbool.h>
+
+#if 0
+                NOTE: ata_idle_nofity usage notes..
+                
+        1) the callbacks are called in the ata thread, not main/your thread.
+        2) Asyncronous callbacks (like the buffer refill) should be avoided.
+            If you must use an async callback, remember to check ata_is_active() before
+            accessing the disk, and nonot call any functions between that check and the
+            disk access which may cause a yield (lcd_update() does this!)
+        3) Do not call cany yielding functions in the callback
+        4) Do not call ata_sleep in the callbacks
+        5) Dont Panic!
+#endif
+
 #define USING_ATA_CALLBACK  !defined(SIMULATOR)             \
                             && !defined(HAVE_FLASH_DISK)    \
                             && !defined(HAVE_MMC)
-                            
+
 #define MAX_ATA_CALLBACKS 5
 typedef bool (*ata_idle_notify)(void);
 
 extern bool register_ata_idle_func(ata_idle_notify function);
 #if USING_ATA_CALLBACK
 extern void ata_idle_notify_init(void);
-extern void unregister_ata_idle_func(ata_idle_notify function);
-extern bool call_ata_idle_notifys(void);
+extern void unregister_ata_idle_func(ata_idle_notify function, bool run);
+extern bool call_ata_idle_notifys(bool sleep_after);
 #else
-#define unregister_ata_idle_func(f)
+#define unregister_ata_idle_func(f,r)
 #define call_ata_idle_notifys()
-#define ata_idle_notify_init()
+#define ata_idle_notify_init(s)
 #endif
 
 #endif /* __ATACALLBACK_H__ */