for WPS files with many lines the current wps code will call puts_scroll with y-values greater than the size of the scroll[] array (e.g. gwps-common.c:2063). This is a temporary security measure until viewports and/or wps tokenizer are available...

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12992 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 4 insertions, 0 deletions

diff --git a/firmware/drivers/lcd-1bit-vert.c b/firmware/drivers/lcd-1bit-vert.c
index 64c1ace292..ec0ddeec41 100644
--- a/firmware/drivers/lcd-1bit-vert.c
+++ b/firmware/drivers/lcd-1bit-vert.c
@@ -692,6 +692,8 @@ void lcd_invertscroll(int x, int y)
 
     (void)x;
 
+    if(y>=SCROLLABLE_LINES) return;
+
     s = &scroll[y];
     s->invert = !s->invert;
 }
@@ -743,6 +745,8 @@ void lcd_puts_scroll_style_offset(int x, int y, const unsigned char *string,
     struct scrollinfo* s;
     int w, h;
 
+    if(y>=SCROLLABLE_LINES) return;
+
     s = &scroll[y];
 
     s->start_tick = current_tick + scroll_delay;