diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-19 10:54:26 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-20 22:41:29 +0100 |
commit | 672bbe434b12d4730cf270f7245753fb98cf162d (patch) | |
tree | 3fdaa08ddc41f942336c968bb169e8806c7c3fa8 /firmware/drivers/isp1583.c | |
parent | 99f333c64f13c3f9a62b9f5e184ae87f053bf65a (diff) | |
download | rockbox-672bbe434b12d4730cf270f7245753fb98cf162d.tar.gz rockbox-672bbe434b12d4730cf270f7245753fb98cf162d.zip |
usb: rename usb_drv_recv() to usb_recv_recv_nonblocking()
IMHO the current name is somewhat misleading:
- usb_drv_send() is blocking and we have usb_drv_send_nonblocking()
for the non-blocking case. This inconsistent naming can only
promote confusion. (And what would we call a blocking receive?)
- Other hardware abstraction APIs in Rockbox are usually blocking:
storage, LCD, backlight, audio... in other words, blocking is the
default expected behavior, with non-blocking calls being a rarity.
Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af
Diffstat (limited to 'firmware/drivers/isp1583.c')
-rw-r--r-- | firmware/drivers/isp1583.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/firmware/drivers/isp1583.c b/firmware/drivers/isp1583.c index c028d2fa01..18a4e9c720 100644 --- a/firmware/drivers/isp1583.c +++ b/firmware/drivers/isp1583.c | |||
@@ -531,9 +531,9 @@ static void in_callback(int ep, unsigned char *buf, int len) | |||
531 | usb_core_transfer_complete(ep, false, 0, len); | 531 | usb_core_transfer_complete(ep, false, 0, len); |
532 | } | 532 | } |
533 | 533 | ||
534 | int usb_drv_recv(int ep, void* ptr, int length) | 534 | int usb_drv_recv_nonblocking(int ep, void* ptr, int length) |
535 | { | 535 | { |
536 | logf("usb_drv_recv(%d, 0x%x, %d)", ep, (int)ptr, length); | 536 | logf("usb_drv_recv_nonblocking(%d, 0x%x, %d)", ep, (int)ptr, length); |
537 | if(ep == EP_CONTROL && length == 0 && ptr == NULL) | 537 | if(ep == EP_CONTROL && length == 0 && ptr == NULL) |
538 | { | 538 | { |
539 | usb_status_ack(ep, DIR_TX); | 539 | usb_status_ack(ep, DIR_TX); |