diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-03-30 20:55:14 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 15:09:51 -0400 |
commit | 8f896b14d32cb338bb18489f3503eedd189c2dc4 (patch) | |
tree | 6782d64b7660a06bcb87d0c7c13edad13ce709e4 /firmware/core_alloc.c | |
parent | 6e9b1b344b7f7b04a2ae4ace0a1d191f63d03396 (diff) | |
download | rockbox-8f896b14d32cb338bb18489f3503eedd189c2dc4.tar.gz rockbox-8f896b14d32cb338bb18489f3503eedd189c2dc4.zip |
buflib: remove the 'name' member from union buflib_data
Using a length 1 char array to point to the name buffer triggers
a -Warray-bounds warning from GCC when fortified strcpy is used.
This type of construct isn't safe in general -- if the compiler
makes assumptions based on the array bound it can create subtle
bugs when accessing the array out of bounds.
Instead, add a function get_block_name() which returns a pointer
to the name field by casting. This suppresses the warning and it
should be a bit more portable.
Change-Id: I25d4f46f799022ad0ec23bef0218f7595cc741ea
Diffstat (limited to 'firmware/core_alloc.c')
0 files changed, 0 insertions, 0 deletions